Skip to content

Commit

Permalink
driver core: Implement ns directory support for device classes.
Browse files Browse the repository at this point in the history
device_del and device_rename were modified to use
sysfs_delete_link and sysfs_rename_link respectively to ensure
when these operations happen on devices whose classes
are in namespace directories they work properly.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Benjamin Thery <benjamin.thery@bull.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Eric W. Biederman authored and Greg Kroah-Hartman committed May 21, 2010
1 parent 746edb7 commit f349cf3
Showing 1 changed file with 12 additions and 9 deletions.
21 changes: 12 additions & 9 deletions drivers/base/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ static int device_add_class_symlinks(struct device *dev)
out_busid:
if (dev->kobj.parent != &dev->class->p->class_subsys.kobj &&
device_is_not_partition(dev))
sysfs_remove_link(&dev->class->p->class_subsys.kobj,
sysfs_delete_link(&dev->class->p->class_subsys.kobj, &dev->kobj,
dev_name(dev));
#else
/* link in the class directory pointing to the device */
Expand All @@ -804,7 +804,7 @@ static int device_add_class_symlinks(struct device *dev)
return 0;

out_busid:
sysfs_remove_link(&dev->class->p->class_subsys.kobj, dev_name(dev));
sysfs_delete_link(&dev->class->p->class_subsys.kobj, &dev->kobj, dev_name(dev));
#endif

out_subsys:
Expand Down Expand Up @@ -832,13 +832,13 @@ static void device_remove_class_symlinks(struct device *dev)

if (dev->kobj.parent != &dev->class->p->class_subsys.kobj &&
device_is_not_partition(dev))
sysfs_remove_link(&dev->class->p->class_subsys.kobj,
sysfs_delete_link(&dev->class->p->class_subsys.kobj, &dev->kobj,
dev_name(dev));
#else
if (dev->parent && device_is_not_partition(dev))
sysfs_remove_link(&dev->kobj, "device");

sysfs_remove_link(&dev->class->p->class_subsys.kobj, dev_name(dev));
sysfs_delete_link(&dev->class->p->class_subsys.kobj, &dev->kobj, dev_name(dev));
#endif

sysfs_remove_link(&dev->kobj, "subsystem");
Expand Down Expand Up @@ -1624,6 +1624,14 @@ int device_rename(struct device *dev, char *new_name)
goto out;
}

#ifndef CONFIG_SYSFS_DEPRECATED
if (dev->class) {
error = sysfs_rename_link(&dev->class->p->class_subsys.kobj,
&dev->kobj, old_device_name, new_name);
if (error)
goto out;
}
#endif
error = kobject_rename(&dev->kobj, new_name);
if (error)
goto out;
Expand All @@ -1638,11 +1646,6 @@ int device_rename(struct device *dev, char *new_name)
new_class_name);
}
}
#else
if (dev->class) {
error = sysfs_rename_link(&dev->class->p->class_subsys.kobj,
&dev->kobj, old_device_name, new_name);
}
#endif

out:
Expand Down

0 comments on commit f349cf3

Please sign in to comment.