Skip to content

Commit

Permalink
[PKTGEN]: Deinitialise static variables.
Browse files Browse the repository at this point in the history
static variables should not be explicitly initialised to 0.  This causes
them to be placed in .data instead of .bss.  This patch de-initialises 3
static variables in net/core/pktgen.c.

There are approximately 800 more such variables in the source tree
(2.6.15rc5).  If there is more interrest I'd be willing to track down the
rest of these as well and de-initialise them as well.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jaco Kroon authored and David S. Miller committed Jan 3, 2006
1 parent 90ddc4f commit f34fbb9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions net/core/pktgen.c
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,9 @@ static unsigned int fmt_ip6(char *s,const char ip[16]);

/* Module parameters, defaults. */
static int pg_count_d = 1000; /* 1000 pkts by default */
static int pg_delay_d = 0;
static int pg_clone_skb_d = 0;
static int debug = 0;
static int pg_delay_d;
static int pg_clone_skb_d;
static int debug;

static DECLARE_MUTEX(pktgen_sem);
static struct pktgen_thread *pktgen_threads = NULL;
Expand Down

0 comments on commit f34fbb9

Please sign in to comment.