Skip to content

Commit

Permalink
V4L/DVB (5846): Clean up setting state and scheduling timeouts
Browse files Browse the repository at this point in the history
Replace assignments to "current->state" with the preferred calls to
schedule_timeout_interruptible().

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Robert P. J. Day authored and Mauro Carvalho Chehab committed Jul 18, 2007
1 parent bd58df6 commit f3a43d3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
6 changes: 2 additions & 4 deletions drivers/media/video/msp3400-driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,7 @@ static int msp_read(struct i2c_client *client, int dev, int addr)
break;
v4l_warn(client, "I/O error #%d (read 0x%02x/0x%02x)\n", err,
dev, addr);
current->state = TASK_INTERRUPTIBLE;
schedule_timeout(msecs_to_jiffies(10));
schedule_timeout_interruptible(msecs_to_jiffies(10));
}
if (err == 3) {
v4l_warn(client, "giving up, resetting chip. Sound will go off, sorry folks :-|\n");
Expand Down Expand Up @@ -197,8 +196,7 @@ static int msp_write(struct i2c_client *client, int dev, int addr, int val)
break;
v4l_warn(client, "I/O error #%d (write 0x%02x/0x%02x)\n", err,
dev, addr);
current->state = TASK_INTERRUPTIBLE;
schedule_timeout(msecs_to_jiffies(10));
schedule_timeout_interruptible(msecs_to_jiffies(10));
}
if (err == 3) {
v4l_warn(client, "giving up, resetting chip. Sound will go off, sorry folks :-|\n");
Expand Down
6 changes: 2 additions & 4 deletions drivers/media/video/vino.c
Original file line number Diff line number Diff line change
Expand Up @@ -2077,12 +2077,10 @@ static int vino_wait_for_frame(struct vino_channel_settings *vcs)
init_waitqueue_entry(&wait, current);
/* add ourselves into wait queue */
add_wait_queue(&vcs->fb_queue.frame_wait_queue, &wait);
/* and set current state */
set_current_state(TASK_INTERRUPTIBLE);

/* to ensure that schedule_timeout will return immediately
* if VINO interrupt was triggred meanwhile */
schedule_timeout(HZ / 10);
* if VINO interrupt was triggered meanwhile */
schedule_timeout_interruptible(HZ / 10);

if (signal_pending(current))
err = -EINTR;
Expand Down

0 comments on commit f3a43d3

Please sign in to comment.