Skip to content

Commit

Permalink
ptrace: move SIGTRAP on exec(2) logic to ptrace_event()
Browse files Browse the repository at this point in the history
Move SIGTRAP on exec(2) logic from tracehook_report_exec() to
ptrace_event().  This is part of changes to make ptrace_event()
smarter and handle ptrace event related details in one place.

This doesn't introduce any behavior change.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
  • Loading branch information
Tejun Heo authored and Oleg Nesterov committed Jun 22, 2011
1 parent 643ad83 commit f3c04b9
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
16 changes: 8 additions & 8 deletions include/linux/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -172,17 +172,17 @@ static inline bool ptrace_event_enabled(struct task_struct *task, int event)
* Check whether @event is enabled and, if so, report @event and @message
* to the ptrace parent.
*
* Returns nonzero if we did a ptrace notification, zero if not.
*
* Called without locks.
*/
static inline int ptrace_event(int event, unsigned long message)
static inline void ptrace_event(int event, unsigned long message)
{
if (likely(!ptrace_event_enabled(current, event)))
return false;
current->ptrace_message = message;
ptrace_notify((event << 8) | SIGTRAP);
return true;
if (unlikely(ptrace_event_enabled(current, event))) {
current->ptrace_message = message;
ptrace_notify((event << 8) | SIGTRAP);
} else if (event == PTRACE_EVENT_EXEC && unlikely(current->ptrace)) {
/* legacy EXEC report via SIGTRAP */
send_sig(SIGTRAP, current, 0);
}
}

/**
Expand Down
4 changes: 1 addition & 3 deletions include/linux/tracehook.h
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,7 @@ static inline void tracehook_report_exec(struct linux_binfmt *fmt,
struct linux_binprm *bprm,
struct pt_regs *regs)
{
if (!ptrace_event(PTRACE_EVENT_EXEC, 0) &&
unlikely(current->ptrace & PT_PTRACED))
send_sig(SIGTRAP, current, 0);
ptrace_event(PTRACE_EVENT_EXEC, 0);
}

/**
Expand Down

0 comments on commit f3c04b9

Please sign in to comment.