Skip to content

Commit

Permalink
staging/xgifb: Remove superfluous header includes
Browse files Browse the repository at this point in the history
This patch removes all unnecessary, redundant and superfluous header
includes from xgifb.

Tested on hp t5325 (XGI Z11)

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Peter Huewe authored and Greg Kroah-Hartman committed Jun 14, 2012
1 parent ac326fb commit f3ca589
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 61 deletions.
6 changes: 0 additions & 6 deletions drivers/staging/xgifb/XGI_main.h
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
#ifndef _XGIFB_MAIN
#define _XGIFB_MAIN


/* ------------------- Constant Definitions ------------------------- */


#include "XGIfb.h"
#include "vb_struct.h"
#include "../../video/sis/sis.h"
#include "vb_def.h"

#define XGIFAIL(x) do { printk(x "\n"); return -EINVAL; } while (0)
Expand Down
26 changes: 1 addition & 25 deletions drivers/staging/xgifb/XGI_main_26.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,36 +6,12 @@

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

/* #include <linux/config.h> */
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/kernel.h>
#include <linux/spinlock.h>
#include <linux/errno.h>
#include <linux/string.h>
#include <linux/mm.h>
#include <linux/tty.h>
#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/fb.h>
#include <linux/console.h>
#include <linux/selection.h>
#include <linux/ioport.h>
#include <linux/init.h>
#include <linux/pci.h>
#include <linux/vt_kern.h>
#include <linux/capability.h>
#include <linux/fs.h>
#include <linux/types.h>
#include <linux/proc_fs.h>

#include <linux/io.h>

#ifdef CONFIG_MTRR
#include <asm/mtrr.h>
#endif

#include "XGIfb.h"
#include "vgatypes.h"
#include "XGI_main.h"
#include "vb_init.h"
#include "vb_util.h"
Expand Down
3 changes: 0 additions & 3 deletions drivers/staging/xgifb/XGIfb.h
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
#ifndef _LINUX_XGIFB
#define _LINUX_XGIFB
#include <linux/ioctl.h>
#include <linux/types.h>

#include "vgatypes.h"
#include "vb_struct.h"

Expand Down
9 changes: 0 additions & 9 deletions drivers/staging/xgifb/vb_init.c
Original file line number Diff line number Diff line change
@@ -1,19 +1,10 @@
#include <linux/types.h>
#include <linux/delay.h> /* udelay */
#include <linux/pci.h>
#include <linux/vmalloc.h>

#include "XGIfb.h"
#include "vgatypes.h"

#include "vb_def.h"
#include "vb_struct.h"
#include "vb_util.h"
#include "vb_setmode.h"
#include "vb_init.h"


#include <linux/io.h>

static const unsigned short XGINew_DDRDRAM_TYPE340[4][5] = {
{ 2, 13, 9, 64, 0x45},
Expand Down
8 changes: 0 additions & 8 deletions drivers/staging/xgifb/vb_setmode.c
Original file line number Diff line number Diff line change
@@ -1,17 +1,9 @@

#include <linux/io.h>
#include <linux/delay.h>
#include <linux/types.h>
#include "XGIfb.h"


#include "vb_def.h"
#include "vgatypes.h"
#include "vb_struct.h"
#include "vb_init.h"
#include "vb_util.h"
#include "vb_table.h"
#include "vb_setmode.h"


#define IndexMask 0xff
Expand Down
9 changes: 0 additions & 9 deletions drivers/staging/xgifb/vb_util.c
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
#include <linux/io.h>
#include <linux/types.h>

#include "vb_def.h"
#include "vgatypes.h"
#include "vb_struct.h"

#include "XGIfb.h"

#include "vb_util.h"

void xgifb_reg_set(unsigned long port, u8 index, u8 data)
{
Expand Down
1 change: 0 additions & 1 deletion drivers/staging/xgifb/vgatypes.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#ifndef _VGATYPES_
#define _VGATYPES_

#include <linux/ioctl.h>
#include <linux/fb.h> /* for struct fb_var_screeninfo for sis.h */
#include "../../video/sis/vgatypes.h"
#include "../../video/sis/sis.h" /* for LCD_TYPE */
Expand Down

0 comments on commit f3ca589

Please sign in to comment.