Skip to content

Commit

Permalink
iwlwifi: fix resart flow after fw error
Browse files Browse the repository at this point in the history
Clear STATUS_FW_ERROR in the _up_ flow before reseting NIC.
UP flow will otherwise call restart again causing endless restart loop.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Emmanuel Grumbach authored and John W. Linville committed Jun 14, 2008
1 parent 64e72c3 commit f3d5b45
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/net/wireless/iwlwifi/iwl4965-base.c
Original file line number Diff line number Diff line change
Expand Up @@ -2857,9 +2857,6 @@ static void iwl_alive_start(struct iwl_priv *priv)
/* After the ALIVE response, we can send host commands to 4965 uCode */
set_bit(STATUS_ALIVE, &priv->status);

/* Clear out the uCode error bit if it is set */
clear_bit(STATUS_FW_ERROR, &priv->status);

if (iwl_is_rfkill(priv))
return;

Expand Down Expand Up @@ -3099,6 +3096,9 @@ static int __iwl4965_up(struct iwl_priv *priv)
continue;
}

/* Clear out the uCode error bit if it is set */
clear_bit(STATUS_FW_ERROR, &priv->status);

/* start card; "initialize" will load runtime ucode */
iwl4965_nic_start(priv);

Expand Down

0 comments on commit f3d5b45

Please sign in to comment.