Skip to content

Commit

Permalink
efifb: Skip DMI checks if the bootloader knows what it's doing
Browse files Browse the repository at this point in the history
The majority of the DMI checks in efifb are for cases where the bootloader
has provided invalid information. However, on some machines the overrides
may do more harm than good due to configuration differences between machines
with the same machine identifier. It turns out that it's possible for the
bootloader to get the correct information on GOP-based systems, but we
can't guarantee that the kernel's being booted with one that's been updated
to do so. Add support for a capabilities flag that can be set by the
bootloader, and skip the DMI checks in that case. Additionally, set this
flag in the UEFI stub code.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
Acked-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
  • Loading branch information
Matthew Garrett authored and Matt Fleming committed Sep 17, 2012
1 parent d6cf86d commit f462ed9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
2 changes: 2 additions & 0 deletions arch/x86/boot/compressed/eboot.c
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,8 @@ static efi_status_t setup_gop(struct screen_info *si, efi_guid_t *proto,
si->rsvd_pos = 0;
}

si->capabilities |= VIDEO_CAPABILITY_SKIP_QUIRKS;

free_handle:
efi_call_phys1(sys_table->boottime->free_pool, gop_handle);
return status;
Expand Down
4 changes: 3 additions & 1 deletion drivers/video/efifb.c
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,9 @@ static int __init efifb_init(void)
int ret;
char *option = NULL;

dmi_check_system(dmi_system_table);
if (screen_info.orig_video_isVGA != VIDEO_TYPE_EFI ||
!(screen_info.capabilities & VIDEO_CAPABILITY_SKIP_QUIRKS))
dmi_check_system(dmi_system_table);

if (screen_info.orig_video_isVGA != VIDEO_TYPE_EFI)
return -ENODEV;
Expand Down
2 changes: 2 additions & 0 deletions include/linux/screen_info.h
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ struct screen_info {

#define VIDEO_FLAGS_NOCURSOR (1 << 0) /* The video mode has no cursor set */

#define VIDEO_CAPABILITY_SKIP_QUIRKS (1 << 0)

#ifdef __KERNEL__
extern struct screen_info screen_info;

Expand Down

0 comments on commit f462ed9

Please sign in to comment.