Skip to content

Commit

Permalink
tools: hv: daemon setsockopt should use options macros
Browse files Browse the repository at this point in the history
HyperV daemon should use macros for option values when calling setsockopt.
Using specific numeric values instead of macros is confusing.

Signed-off-by: Tomas Hozza <thozza@redhat.com>
Acked-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Tomas Hozza authored and Greg Kroah-Hartman committed Mar 15, 2013
1 parent 77d6a52 commit f4685fa
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions tools/hv/hv_kvp_daemon.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ static struct utsname uts_buf;
#define MAX_FILE_NAME 100
#define ENTRIES_PER_BLOCK 50

#ifndef SOL_NETLINK
#define SOL_NETLINK 270
#endif

struct kvp_record {
char key[HV_KVP_EXCHANGE_MAX_KEY_SIZE];
char value[HV_KVP_EXCHANGE_MAX_VALUE_SIZE];
Expand Down Expand Up @@ -1407,7 +1411,7 @@ netlink_send(int fd, struct cn_msg *msg)

int main(void)
{
int fd, len, sock_opt;
int fd, len, nl_group;
int error;
struct cn_msg *message;
struct pollfd pfd;
Expand Down Expand Up @@ -1452,8 +1456,8 @@ int main(void)
close(fd);
exit(EXIT_FAILURE);
}
sock_opt = CN_KVP_IDX;
setsockopt(fd, 270, 1, &sock_opt, sizeof(sock_opt));
nl_group = CN_KVP_IDX;
setsockopt(fd, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP, &nl_group, sizeof(nl_group));
/*
* Register ourselves with the kernel.
*/
Expand Down

0 comments on commit f4685fa

Please sign in to comment.