Skip to content

Commit

Permalink
is_power_of_2(): jbd
Browse files Browse the repository at this point in the history 
Replace (n & (n-1)) in the context of power of 2 checks with
is_power_of_2().

Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
vignesh babu authored and Linus Torvalds committed Jul 16, 2007
1 parent 3fc7426 commit f482394
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions fs/jbd/revoke.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
#include <linux/list.h>
#include <linux/init.h>
#endif
#include <linux/log2.h>

static struct kmem_cache *revoke_record_cache;
static struct kmem_cache *revoke_table_cache;
Expand Down Expand Up @@ -211,7 +212,7 @@ int journal_init_revoke(journal_t *journal, int hash_size)
journal->j_revoke = journal->j_revoke_table[0];

/* Check that the hash_size is a power of two */
J_ASSERT ((hash_size & (hash_size-1)) == 0);
J_ASSERT(is_power_of_2(hash_size));

journal->j_revoke->hash_size = hash_size;

Expand All @@ -238,7 +239,7 @@ int journal_init_revoke(journal_t *journal, int hash_size)
journal->j_revoke = journal->j_revoke_table[1];

/* Check that the hash_size is a power of two */
J_ASSERT ((hash_size & (hash_size-1)) == 0);
J_ASSERT(is_power_of_2(hash_size));

journal->j_revoke->hash_size = hash_size;

Expand Down
5 changes: 3 additions & 2 deletions fs/jbd2/revoke.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
#include <linux/list.h>
#include <linux/init.h>
#endif
#include <linux/log2.h>

static struct kmem_cache *jbd2_revoke_record_cache;
static struct kmem_cache *jbd2_revoke_table_cache;
Expand Down Expand Up @@ -212,7 +213,7 @@ int jbd2_journal_init_revoke(journal_t *journal, int hash_size)
journal->j_revoke = journal->j_revoke_table[0];

/* Check that the hash_size is a power of two */
J_ASSERT ((hash_size & (hash_size-1)) == 0);
J_ASSERT(is_power_of_2(hash_size));

journal->j_revoke->hash_size = hash_size;

Expand All @@ -239,7 +240,7 @@ int jbd2_journal_init_revoke(journal_t *journal, int hash_size)
journal->j_revoke = journal->j_revoke_table[1];

/* Check that the hash_size is a power of two */
J_ASSERT ((hash_size & (hash_size-1)) == 0);
J_ASSERT(is_power_of_2(hash_size));

journal->j_revoke->hash_size = hash_size;

Expand Down

0 comments on commit f482394

Please sign in to comment.