Skip to content

Commit

Permalink
[NET]: Fix ___pskb_trim when entire frag_list needs dropping
Browse files Browse the repository at this point in the history
When the trim point is within the head and there is no paged data,
___pskb_trim fails to drop the first element in the frag_list.
This patch fixes this by moving the len <= offset case out of the
page data loop.

This patch also adds a missing kfree_skb on the frag that we just
cloned.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Herbert Xu authored and David S. Miller committed Aug 2, 2006
1 parent 9cd3ecd commit f4d26fb
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions net/core/skbuff.c
Original file line number Diff line number Diff line change
Expand Up @@ -846,25 +846,29 @@ int ___pskb_trim(struct sk_buff *skb, unsigned int len)
unlikely((err = pskb_expand_head(skb, 0, 0, GFP_ATOMIC))))
return err;

for (i = 0; i < nfrags; i++) {
i = 0;
if (offset >= len)
goto drop_pages;

for (; i < nfrags; i++) {
int end = offset + skb_shinfo(skb)->frags[i].size;

if (end < len) {
offset = end;
continue;
}

if (len > offset)
skb_shinfo(skb)->frags[i++].size = len - offset;
skb_shinfo(skb)->frags[i++].size = len - offset;

drop_pages:
skb_shinfo(skb)->nr_frags = i;

for (; i < nfrags; i++)
put_page(skb_shinfo(skb)->frags[i].page);

if (skb_shinfo(skb)->frag_list)
skb_drop_fraglist(skb);
break;
goto done;
}

for (fragp = &skb_shinfo(skb)->frag_list; (frag = *fragp);
Expand All @@ -879,6 +883,7 @@ int ___pskb_trim(struct sk_buff *skb, unsigned int len)
return -ENOMEM;

nfrag->next = frag->next;
kfree_skb(frag);
frag = nfrag;
*fragp = frag;
}
Expand All @@ -897,6 +902,7 @@ int ___pskb_trim(struct sk_buff *skb, unsigned int len)
break;
}

done:
if (len > skb_headlen(skb)) {
skb->data_len -= skb->len - len;
skb->len = len;
Expand Down

0 comments on commit f4d26fb

Please sign in to comment.