Skip to content

Commit

Permalink
libceph: set page alignment in start_request()
Browse files Browse the repository at this point in the history
The page alignment field for a request is currently set in
ceph_osdc_build_request().  It's not needed at that point
nor do either of its callers need that value assigned at
any point before they call ceph_osdc_start_request().

So move that assignment into ceph_osdc_start_request().

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
  • Loading branch information
Alex Elder authored and Sage Weil committed May 2, 2013
1 parent d4b515f commit f51a822
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ceph/osd_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,6 @@ void ceph_osdc_build_request(struct ceph_osd_request *req,
data_len += len;
}
req->r_request->hdr.data_len = cpu_to_le32(data_len);
req->r_request->page_alignment = req->r_page_alignment;

BUG_ON(p > msg->front.iov_base + msg->front.iov_len);
msg_size = p - msg->front.iov_base;
Expand Down Expand Up @@ -1743,6 +1742,7 @@ int ceph_osdc_start_request(struct ceph_osd_client *osdc,

req->r_request->pages = req->r_pages;
req->r_request->page_count = req->r_num_pages;
req->r_request->page_alignment = req->r_page_alignment;
#ifdef CONFIG_BLOCK
req->r_request->bio = req->r_bio;
#endif
Expand Down

0 comments on commit f51a822

Please sign in to comment.