Skip to content

Commit

Permalink
iwlwifi: fix current channel is not scanned
Browse files Browse the repository at this point in the history
All channels should be scanned, including the current channel
when the client is associated.

Removed also unused flag to scan only active channels.

Signed-off-by: Guy Cohen <guy.cohen@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Guy Cohen authored and John W. Linville committed May 1, 2008
1 parent 21a75d7 commit f527648
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 28 deletions.
1 change: 0 additions & 1 deletion drivers/net/wireless/iwlwifi/iwl-3945.h
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,6 @@ struct iwl3945_priv {
u8 direct_ssid_len;
u8 direct_ssid[IW_ESSID_MAX_SIZE];
struct iwl3945_scan_cmd *scan;
u8 only_active_channel;

/* spinlock */
spinlock_t lock; /* protect general shared data */
Expand Down
1 change: 0 additions & 1 deletion drivers/net/wireless/iwlwifi/iwl-4965.h
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,6 @@ struct iwl_priv {
u8 direct_ssid_len;
u8 direct_ssid[IW_ESSID_MAX_SIZE];
struct iwl4965_scan_cmd *scan;
u8 only_active_channel;

/* spinlock */
spinlock_t lock; /* protect general shared data */
Expand Down
13 changes: 0 additions & 13 deletions drivers/net/wireless/iwlwifi/iwl3945-base.c
Original file line number Diff line number Diff line change
Expand Up @@ -4968,17 +4968,6 @@ static int iwl3945_get_channels_for_scan(struct iwl3945_priv *priv,
if (channels[i].flags & IEEE80211_CHAN_DISABLED)
continue;

if (channels[i].hw_value ==
le16_to_cpu(priv->active_rxon.channel)) {
if (iwl3945_is_associated(priv)) {
IWL_DEBUG_SCAN
("Skipping current channel %d\n",
le16_to_cpu(priv->active_rxon.channel));
continue;
}
} else if (priv->only_active_channel)
continue;

scan_ch->channel = channels[i].hw_value;

ch_info = iwl3945_get_channel_info(priv, band, scan_ch->channel);
Expand Down Expand Up @@ -7314,8 +7303,6 @@ static void iwl3945_mac_reset_tsf(struct ieee80211_hw *hw)
return;
}

priv->only_active_channel = 0;

iwl3945_set_rate(priv);

mutex_unlock(&priv->mutex);
Expand Down
13 changes: 0 additions & 13 deletions drivers/net/wireless/iwlwifi/iwl4965-base.c
Original file line number Diff line number Diff line change
Expand Up @@ -4633,17 +4633,6 @@ static int iwl4965_get_channels_for_scan(struct iwl_priv *priv,
if (channels[i].flags & IEEE80211_CHAN_DISABLED)
continue;

if (ieee80211_frequency_to_channel(channels[i].center_freq) ==
le16_to_cpu(priv->active_rxon.channel)) {
if (iwl_is_associated(priv)) {
IWL_DEBUG_SCAN
("Skipping current channel %d\n",
le16_to_cpu(priv->active_rxon.channel));
continue;
}
} else if (priv->only_active_channel)
continue;

scan_ch->channel = ieee80211_frequency_to_channel(channels[i].center_freq);

ch_info = iwl_get_channel_info(priv, band,
Expand Down Expand Up @@ -7061,8 +7050,6 @@ static void iwl4965_mac_reset_tsf(struct ieee80211_hw *hw)
return;
}

priv->only_active_channel = 0;

iwl4965_set_rate(priv);

mutex_unlock(&priv->mutex);
Expand Down

0 comments on commit f527648

Please sign in to comment.