Skip to content

Commit

Permalink
ASoC: simple-card: tidyup use priv in parameter
Browse files Browse the repository at this point in the history
priv has many information about simple-card driver.
Using it becomes easy to extend feature.
This patch gets dev from priv as 1st step

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Kuninori Morimoto authored and Mark Brown committed Sep 12, 2014
1 parent 88a60e5 commit f531913
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions sound/soc/generic/simple-card.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ struct simple_card_data {
struct snd_soc_dai_link dai_link[]; /* dynamically allocated */
};

#define simple_priv_to_dev(priv) ((priv)->snd_card.dev)

static int asoc_simple_card_hw_params(struct snd_pcm_substream *substream,
struct snd_pcm_hw_params *params)
{
Expand Down Expand Up @@ -170,11 +172,12 @@ asoc_simple_card_sub_parse_of(struct device_node *np,
}

static int asoc_simple_card_dai_link_of(struct device_node *node,
struct device *dev,
struct simple_card_data *priv,
struct snd_soc_dai_link *dai_link,
struct simple_dai_props *dai_props,
bool is_top_level_node)
{
struct device *dev = simple_priv_to_dev(priv);
struct device_node *np = NULL;
struct device_node *bitclkmaster = NULL;
struct device_node *framemaster = NULL;
Expand Down Expand Up @@ -319,9 +322,9 @@ static int asoc_simple_card_dai_link_of(struct device_node *node,
}

static int asoc_simple_card_parse_of(struct device_node *node,
struct simple_card_data *priv,
struct device *dev)
struct simple_card_data *priv)
{
struct device *dev = simple_priv_to_dev(priv);
struct snd_soc_dai_link *dai_link = priv->snd_card.dai_link;
struct simple_dai_props *dai_props = priv->dai_props;
u32 val;
Expand Down Expand Up @@ -364,7 +367,7 @@ static int asoc_simple_card_parse_of(struct device_node *node,

for_each_child_of_node(node, np) {
dev_dbg(dev, "\tlink %d:\n", i);
ret = asoc_simple_card_dai_link_of(np, dev,
ret = asoc_simple_card_dai_link_of(np, priv,
dai_link + i,
dai_props + i,
false);
Expand All @@ -376,7 +379,7 @@ static int asoc_simple_card_parse_of(struct device_node *node,
}
} else {
/* For single DAI link & old style of DT node */
ret = asoc_simple_card_dai_link_of(node, dev,
ret = asoc_simple_card_dai_link_of(node, priv,
dai_link, dai_props, true);
if (ret < 0)
return ret;
Expand Down Expand Up @@ -446,7 +449,7 @@ static int asoc_simple_card_probe(struct platform_device *pdev)

if (np && of_device_is_available(np)) {

ret = asoc_simple_card_parse_of(np, priv, dev);
ret = asoc_simple_card_parse_of(np, priv);
if (ret < 0) {
if (ret != -EPROBE_DEFER)
dev_err(dev, "parse error %d\n", ret);
Expand Down

0 comments on commit f531913

Please sign in to comment.