Skip to content

Commit

Permalink
isci: Requests that do not start must be set to "complete"
Browse files Browse the repository at this point in the history
Requests that fail at start because of a reset pending condition
must be set to complete in order to allow for later cleanup.

Signed-off-by: Jeff Skirvin <jeffrey.d.skirvin@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
Jeff Skirvin authored and Dan Williams committed Jul 3, 2011
1 parent cde76fb commit f53a3a3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/scsi/isci/request.c
Original file line number Diff line number Diff line change
Expand Up @@ -3678,18 +3678,19 @@ int isci_request_execute(
* Update it's status and add it to the list in the
* remote device object.
*/
isci_request_change_state(request, started);
list_add(&request->dev_node, &isci_device->reqs_in_process);

if (status == SCI_SUCCESS) {
/* Save the tag for possible task mgmt later. */
request->io_tag = request->sci.io_tag;
isci_request_change_state(request, started);
} else {
/* The request did not really start in the
* hardware, so clear the request handle
* here so no terminations will be done.
*/
request->terminated = true;
isci_request_change_state(request, completed);
}
spin_unlock_irqrestore(&isci_host->scic_lock, flags);

Expand Down

0 comments on commit f53a3a3

Please sign in to comment.