Skip to content

Commit

Permalink
cpufreq: tegra: call CPUFREQ_POSTCHANGE notfier in error cases
Browse files Browse the repository at this point in the history
PRECHANGE and POSTCHANGE notifiers must be called in groups, i.e either both
should be called or both shouldn't be.

In case we have started PRECHANGE notifier and found an error, we must call
POSTCHANGE notifier with freqs.new = freqs.old to guarantee that sequence of
calling notifiers is complete.

This patch fixes it.

Acked-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
  • Loading branch information
Viresh Kumar committed Jun 24, 2013
1 parent 6cdc9ef commit f56cc99
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/cpufreq/tegra-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,12 @@ static int tegra_update_cpu_speed(struct cpufreq_policy *policy,
if (ret) {
pr_err("cpu-tegra: Failed to set cpu frequency to %d kHz\n",
freqs.new);
return ret;
freqs.new = freqs.old;
}

cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);

return 0;
return ret;
}

static unsigned long tegra_cpu_highest_speed(void)
Expand Down

0 comments on commit f56cc99

Please sign in to comment.