Skip to content

Commit

Permalink
x86: no CPA on iounmap
Browse files Browse the repository at this point in the history
When an ioremap is unmapped, do not change the page attributes. There might
be another mapping of the same physical address. PAT might detect a conflicting
mapping attribute for no good reason. The mapping is removed anyway.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Thomas Gleixner authored and Ingo Molnar committed Feb 4, 2008
1 parent 75ab43b commit f56d005
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions arch/x86/mm/ioremap.c
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,6 @@ void iounmap(volatile void __iomem *addr)
return;
}

/* Reset the direct mapping. Can block */
ioremap_change_attr(p->phys_addr, p->size, IOR_MODE_CACHED);

/* Finally remove it */
o = remove_vm_area((void *)addr);
BUG_ON(p != o || o == NULL);
Expand Down

0 comments on commit f56d005

Please sign in to comment.