Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 108990
b: refs/heads/master
c: c906a48
h: refs/heads/master
v: v3
  • Loading branch information
Greg Kroah-Hartman committed Aug 21, 2008
1 parent 7a4773c commit f56e9e3
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 8 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 3b98aeaf3a75f544dc945694f4fcf6e1c4bab89d
refs/heads/master: c906a48adc74fc455378137ac5124b13e7030a15
20 changes: 13 additions & 7 deletions trunk/drivers/base/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -844,13 +844,19 @@ int device_add(struct device *dev)
{
struct device *parent = NULL;
struct class_interface *class_intf;
int error;
int error = -EINVAL;

dev = get_device(dev);
if (!dev || !strlen(dev->bus_id)) {
error = -EINVAL;
goto Done;
}
if (!dev)
goto done;

/* Temporarily support init_name if it is set.
* It will override bus_id for now */
if (dev->init_name)
dev_set_name(dev, "%s", dev->init_name);

if (!strlen(dev->bus_id))
goto done;

pr_debug("device: '%s': %s\n", dev->bus_id, __func__);

Expand Down Expand Up @@ -919,7 +925,7 @@ int device_add(struct device *dev)
class_intf->add_dev(dev, class_intf);
mutex_unlock(&dev->class->p->class_mutex);
}
Done:
done:
put_device(dev);
return error;
DPMError:
Expand All @@ -946,7 +952,7 @@ int device_add(struct device *dev)
cleanup_device_parent(dev);
if (parent)
put_device(parent);
goto Done;
goto done;
}

/**
Expand Down
1 change: 1 addition & 0 deletions trunk/include/linux/device.h
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ struct device {

struct kobject kobj;
char bus_id[BUS_ID_SIZE]; /* position on parent bus */
const char *init_name; /* initial name of the device */
struct device_type *type;
unsigned uevent_suppress:1;

Expand Down

0 comments on commit f56e9e3

Please sign in to comment.