ceph: fix dentry reference leak in dcache readdir

When filldir returned an error (e.g. buffer full for a large directory), we would leak a dentry reference, causing an oops on umount. Signed-off-by: Sage Weil <sage@newdream.net>
git-mirror · Apr 12, 2010 · f5b0662 · f5b0662
1 parent 2844a76
commit f5b0662
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
@@ -170,11 +170,11 @@ static int __dcache_readdir(struct file *filp,
 	spin_lock(&inode->i_lock);
 	spin_lock(&dcache_lock);
 
+	last = dentry;
+
 	if (err < 0)
 		goto out_unlock;
 
-	last = dentry;
-
 	p = p->prev;
 	filp->f_pos++;