Skip to content

Commit

Permalink
OMAP: hwmod: Do not exit the iteration if one clock init failed
Browse files Browse the repository at this point in the history
During the _init_clocks phase, the iteration is stopped but the
status is still change from _HWMOD_STATE_REGISTERED to
_HWMOD_STATE_CLKS_INITED.
Since the _setup phase will be done nevertheless, it might be
better to keep initializing the others clocks nodes and just
keep the warning.
It is much easier to debug when a important number of clocks
name are wrong during the early debug phase of a new platform.

Signed-off-by: Benoit Cousson <b-cousson@ti.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
  • Loading branch information
Benoit Cousson authored and Paul Walmsley committed May 20, 2010
1 parent 20383d8 commit f5c1f84
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions arch/arm/mach-omap2/omap_hwmod.c
Original file line number Diff line number Diff line change
Expand Up @@ -783,9 +783,10 @@ static int _init_clocks(struct omap_hwmod *oh)
ret |= _init_interface_clks(oh);
ret |= _init_opt_clks(oh);

oh->_state = _HWMOD_STATE_CLKS_INITED;
if (!ret)
oh->_state = _HWMOD_STATE_CLKS_INITED;

return ret;
return 0;
}

/**
Expand Down

0 comments on commit f5c1f84

Please sign in to comment.