Skip to content

Commit

Permalink
brcm80211: Allow trace support to be enabled separately from debug
Browse files Browse the repository at this point in the history
Since the runtime overhead of trace support is small when tracing is
disabled, users may be interested in turning on trace support while
leaving other debug features off. Add a new config option named
CONFIG_BRCM_TRACING for this purpose.

Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Tested-by: Daniel Wagner <wagi@monom.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Seth Forshee authored and John W. Linville committed Nov 20, 2012
1 parent 75be3e2 commit f5c4f10
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
11 changes: 11 additions & 0 deletions drivers/net/wireless/brcm80211/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,17 @@ config BRCMFMAC_USB
IEEE802.11n embedded FullMAC WLAN driver. Say Y if you want to
use the driver for an USB wireless card.

config BRCM_TRACING
bool "Broadcom device tracing"
depends on BRCMSMAC || BRCMFMAC
---help---
If you say Y here, the Broadcom wireless drivers will register
with ftrace to dump event information into the trace ringbuffer.
Tracing can be enabled at runtime to aid in debugging wireless
issues. This option adds a small amount of overhead when tracing
is disabled. If unsure, say Y to allow developers to better help
you when wireless problems occur.

config BRCMDBG
bool "Broadcom driver debug functions"
depends on BRCMSMAC || BRCMFMAC
Expand Down
6 changes: 3 additions & 3 deletions drivers/net/wireless/brcm80211/brcmsmac/brcms_trace_events.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#include <linux/tracepoint.h>
#include "mac80211_if.h"

#ifndef CONFIG_BRCMDBG
#ifndef CONFIG_BRCM_TRACING
#undef TRACE_EVENT
#define TRACE_EVENT(name, proto, ...) \
static inline void trace_ ## name(proto) {}
Expand Down Expand Up @@ -80,7 +80,7 @@ TRACE_EVENT(brcms_dpc,

#endif /* __TRACE_BRCMSMAC_H */

#ifdef CONFIG_BRCMDBG
#ifdef CONFIG_BRCM_TRACING

#undef TRACE_INCLUDE_PATH
#define TRACE_INCLUDE_PATH .
Expand All @@ -89,4 +89,4 @@ TRACE_EVENT(brcms_dpc,

#include <trace/define_trace.h>

#endif /* CONFIG_BRCMDBG */
#endif /* CONFIG_BRCM_TRACING */

0 comments on commit f5c4f10

Please sign in to comment.