Skip to content

Commit

Permalink
netfilter: nf_conntrack: fix lifetime display for disabled connections
Browse files Browse the repository at this point in the history
When no tstamp extension exists, ct_delta_time() returns -1, which is
then assigned to an u64 and tested for negative values to decide
whether to display the lifetime. This obviously doesn't work, use
a s64 and merge the two minor functions into one.

Signed-off-by: Patrick McHardy <kaber@trash.net>
  • Loading branch information
Patrick McHardy committed Jan 19, 2011
1 parent a992ca2 commit f5c88f5
Showing 1 changed file with 12 additions and 17 deletions.
29 changes: 12 additions & 17 deletions net/netfilter/nf_conntrack_standalone.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,29 +141,24 @@ static inline int ct_show_secctx(struct seq_file *s, const struct nf_conn *ct)
#endif

#ifdef CONFIG_NF_CONNTRACK_TIMESTAMP
static u_int64_t ct_delta_time(u_int64_t time_now, const struct nf_conn *ct)
static int ct_show_delta_time(struct seq_file *s, const struct nf_conn *ct)
{
struct ct_iter_state *st = s->private;
struct nf_conn_tstamp *tstamp;
s64 delta_time;

tstamp = nf_conn_tstamp_find(ct);
if (tstamp) {
u_int64_t delta_time = time_now - tstamp->start;
return delta_time > 0 ? div_s64(delta_time, NSEC_PER_SEC) : 0;
delta_time = st->time_now - tstamp->start;
if (delta_time > 0)
delta_time = div_s64(delta_time, NSEC_PER_SEC);
else
delta_time = 0;

return seq_printf(s, "delta-time=%llu ",
(unsigned long long)delta_time);
}
return -1;
}

static int ct_show_delta_time(struct seq_file *s, const struct nf_conn *ct)
{
struct ct_iter_state *st = s->private;
u_int64_t delta_time;

delta_time = ct_delta_time(st->time_now, ct);
if (delta_time < 0)
return 0;

return seq_printf(s, "delta-time=%llu ",
(unsigned long long)delta_time);
return 0;
}
#else
static inline int
Expand Down

0 comments on commit f5c88f5

Please sign in to comment.