Skip to content

Commit

Permalink
[PATCH] ppc64: don't create spurious symlinks under node0 sysdev
Browse files Browse the repository at this point in the history
On partitioned systems we can wind up creating spurious symlinks in
/sys/devices/system/node/node0 to non-present cpus.  The symlinks are
not broken; the problem is that we're potentially misinforming
userspace that there is a relationship between node0 and cpus which
are to be added later.  There's no guarantee at all that a cpu which
is added later will belong to node 0.

Signed-off-by: Nathan Lynch <ntl@pobox.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Nathan Lynch authored and Paul Mackerras committed Jun 28, 2005
1 parent a341ad9 commit f5f1cc5
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion arch/ppc64/kernel/sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,12 @@ static int __init topology_init(void)
struct cpu *c = &per_cpu(cpu_devices, cpu);

#ifdef CONFIG_NUMA
parent = &node_devices[cpu_to_node(cpu)];
/* The node to which a cpu belongs can't be known
* until the cpu is made present.
*/
parent = NULL;
if (cpu_present(cpu))
parent = &node_devices[cpu_to_node(cpu)];
#endif
/*
* For now, we just see if the system supports making
Expand Down

0 comments on commit f5f1cc5

Please sign in to comment.