Skip to content

Commit

Permalink
hwmon: (tmp421) Convert to use devm_ functions
Browse files Browse the repository at this point in the history
Convert to use devm_ functions to reduce code size and simplify the code.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>
  • Loading branch information
Guenter Roeck committed Jul 22, 2012
1 parent 0df9fc7 commit f625e0f
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions drivers/hwmon/tmp421.c
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,8 @@ static int tmp421_probe(struct i2c_client *client,
struct tmp421_data *data;
int err;

data = kzalloc(sizeof(struct tmp421_data), GFP_KERNEL);
data = devm_kzalloc(&client->dev, sizeof(struct tmp421_data),
GFP_KERNEL);
if (!data)
return -ENOMEM;

Expand All @@ -277,11 +278,11 @@ static int tmp421_probe(struct i2c_client *client,

err = tmp421_init_client(client);
if (err)
goto exit_free;
return err;

err = sysfs_create_group(&client->dev.kobj, &tmp421_group);
if (err)
goto exit_free;
return err;

data->hwmon_dev = hwmon_device_register(&client->dev);
if (IS_ERR(data->hwmon_dev)) {
Expand All @@ -293,10 +294,6 @@ static int tmp421_probe(struct i2c_client *client,

exit_remove:
sysfs_remove_group(&client->dev.kobj, &tmp421_group);

exit_free:
kfree(data);

return err;
}

Expand All @@ -307,8 +304,6 @@ static int tmp421_remove(struct i2c_client *client)
hwmon_device_unregister(data->hwmon_dev);
sysfs_remove_group(&client->dev.kobj, &tmp421_group);

kfree(data);

return 0;
}

Expand Down

0 comments on commit f625e0f

Please sign in to comment.