Skip to content

Commit

Permalink
ata: libahci: Use of_platform_device_create only if supported
Browse files Browse the repository at this point in the history
of_platform_device_create does not exist if OF_ADDRESS is not configured,
so limit its use accordingly.

Without this fix, the sparc64:allmodconfig build fails with

ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined!

Fixes: c7d7dde ("ata: libahci: Allow using multiple regulators")
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Guenter Roeck authored and Tejun Heo committed Feb 3, 2015
1 parent fad0601 commit f627cfd
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/ata/libahci_platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
if (child_nodes) {
for_each_child_of_node(dev->of_node, child) {
u32 port;
struct platform_device *port_dev;
struct platform_device *port_dev __maybe_unused;

if (!of_device_is_available(child))
continue;
Expand All @@ -434,6 +434,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
}
mask_port_map |= BIT(port);

#ifdef CONFIG_OF_ADDRESS
of_platform_device_create(child, NULL, NULL);

port_dev = of_find_device_by_node(child);
Expand All @@ -444,6 +445,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
if (rc == -EPROBE_DEFER)
goto err_out;
}
#endif

rc = ahci_platform_get_phy(hpriv, port, dev, child);
if (rc)
Expand Down

0 comments on commit f627cfd

Please sign in to comment.