Skip to content

Commit

Permalink
[DCCP]: Warn when discarding packet due to internal errors
Browse files Browse the repository at this point in the history
This adds a (debug) warning message which is triggered whenever a packet is
discarded due to send failure.

It also adds a conditional, so that an interruption during dccp_wait_for_ccid
is not treated as a `BUG': the rationale is that interruptions are external,
whereas bug warnings are concerned with the internals.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
  • Loading branch information
Gerrit Renker authored and David S. Miller committed Dec 11, 2006
1 parent bf58a38 commit f6282f4
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions net/dccp/output.c
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ void dccp_write_xmit(struct sock *sk, int block)
break;
} else
err = dccp_wait_for_ccid(sk, skb);
if (err)
if (err && err != -EINTR)
DCCP_BUG("err=%d after dccp_wait_for_ccid", err);
}

Expand All @@ -267,8 +267,10 @@ void dccp_write_xmit(struct sock *sk, int block)
if (err)
DCCP_BUG("err=%d after ccid_hc_tx_packet_sent",
err);
} else
} else {
dccp_pr_debug("packet discarded\n");
kfree(skb);
}
}
}

Expand Down

0 comments on commit f6282f4

Please sign in to comment.