Skip to content

Commit

Permalink
[ARM] pxa: remove useless pxa_pm_finish() function
Browse files Browse the repository at this point in the history
pxa_pm_finish() does nothing but return zero.  The core code
does nothing with this return value, and will not try to call
the finish method in the pm_ops structure if it is NULL.

Therefore, we can remove this useless function.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Russell King committed Jul 12, 2007
1 parent 7dcca30 commit f62c3f2
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 13 deletions.
1 change: 0 additions & 1 deletion arch/arm/common/sharpsl_pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,6 @@ static void sharpsl_apm_get_power_status(struct apm_power_info *info)
static struct pm_ops sharpsl_pm_ops = {
.prepare = pxa_pm_prepare,
.enter = corgi_pxa_pm_enter,
.finish = pxa_pm_finish,
.valid = pm_valid_only_mem,
};

Expand Down
11 changes: 0 additions & 11 deletions arch/arm/mach-pxa/pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -213,20 +213,9 @@ int pxa_pm_prepare(suspend_state_t state)

EXPORT_SYMBOL_GPL(pxa_pm_prepare);

/*
* Called after devices are re-setup, but before processes are thawed.
*/
int pxa_pm_finish(suspend_state_t state)
{
return 0;
}

EXPORT_SYMBOL_GPL(pxa_pm_finish);

static struct pm_ops pxa_pm_ops = {
.prepare = pxa_pm_prepare,
.enter = pxa_pm_enter,
.finish = pxa_pm_finish,
.valid = pm_valid_only_mem,
};

Expand Down
1 change: 0 additions & 1 deletion include/asm-arm/arch-pxa/pm.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@

extern int pxa_pm_prepare(suspend_state_t state);
extern int pxa_pm_enter(suspend_state_t state);
extern int pxa_pm_finish(suspend_state_t state);

0 comments on commit f62c3f2

Please sign in to comment.