Skip to content

Commit

Permalink
USB: gadget: ci13xx_udc: fix potential crash in irq handler
Browse files Browse the repository at this point in the history
As pointed out by Dan Carpenter, we should not be trying to call
dev_err() on a structure that was previously determined to be NULL,
that's just foolish and asking for trouble.

So just delete the message, it's not going to do anyone any good to have
it anyway.

This problem was caused by 0f08909: "usb: gadget: ci13xxx: replace
home-brewed logging with dev_{err,warn,info}"

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed May 10, 2012
1 parent 126625e commit f639554
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/usb/gadget/ci13xxx_udc.c
Original file line number Diff line number Diff line change
Expand Up @@ -2719,10 +2719,8 @@ static irqreturn_t udc_irq(int irq, void *data)

trace(udc ? udc->dev : NULL, "");

if (udc == NULL) {
dev_err(udc->dev, "ENODEV");
if (udc == NULL)
return IRQ_HANDLED;
}

spin_lock(&udc->lock);

Expand Down

0 comments on commit f639554

Please sign in to comment.