Skip to content

Commit

Permalink
[MTD] [NAND] remove __PPC__ hardcoded address from DiskOnChip drivers
Browse files Browse the repository at this point in the history
Such a hardcoded address can cause a checkstop or machine check if
the driver is in the kernel but the address is not acknowledged.

Both drivers allow an address to be specified as either a module
parameter or config option.   Any future powerpc board should either
use one of these methods or find the address in the device tree.

Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
  • Loading branch information
Milton Miller authored and David Woodhouse committed Jul 11, 2008
1 parent 6f40470 commit f63af11
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions drivers/mtd/devices/docprobe.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ static unsigned long __initdata doc_locations[] = {
0xe0000, 0xe2000, 0xe4000, 0xe6000,
0xe8000, 0xea000, 0xec000, 0xee000,
#endif /* CONFIG_MTD_DOCPROBE_HIGH */
#elif defined(__PPC__)
0xe4000000,
#else
#warning Unknown architecture for DiskOnChip. No default probe locations defined
#endif
Expand Down
2 changes: 0 additions & 2 deletions drivers/mtd/nand/diskonchip.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ static unsigned long __initdata doc_locations[] = {
0xe0000, 0xe2000, 0xe4000, 0xe6000,
0xe8000, 0xea000, 0xec000, 0xee000,
#endif /* CONFIG_MTD_DOCPROBE_HIGH */
#elif defined(__PPC__)
0xe4000000,
#else
#warning Unknown architecture for DiskOnChip. No default probe locations defined
#endif
Expand Down

0 comments on commit f63af11

Please sign in to comment.