Skip to content

Commit

Permalink
clk:at91: Fix memory leak in of_at91_clk_master_setup()
Browse files Browse the repository at this point in the history
cppcheck detected following error
[clk-master.c:245]: (error) Memory leak: characteristics

The original code forgot to free characteristics when
irq_of_parse_and_map() failed.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Acked-by Boris BREZILLON <b.brezillon@overkiz.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
  • Loading branch information
Masanari Iida authored and Mike Turquette committed Feb 27, 2014
1 parent ec6deea commit f63fcc9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/clk/at91/clk-master.c
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np, struct at91_pmc *pmc,

irq = irq_of_parse_and_map(np, 0);
if (!irq)
return;
goto out_free_characteristics;

clk = at91_clk_register_master(pmc, irq, name, num_parents,
parent_names, layout,
Expand Down

0 comments on commit f63fcc9

Please sign in to comment.