Skip to content

Commit

Permalink
tools lib traceevent: Fix off-by-one bug in pevent_strerror()
Browse files Browse the repository at this point in the history
As pevent_errno is defined using PEVENT_ERRORS which uses _PE macro
magic, the first errno is bigger than __PEVENT_ERRNO_START by 1. So we
need to subtract the 1 also when calculating the index of the error
strings.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1345707420-21767-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Namhyung Kim authored and Arnaldo Carvalho de Melo committed Aug 23, 2012
1 parent e1aa7c3 commit f63fe79
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/lib/traceevent/event-parse.c
Original file line number Diff line number Diff line change
Expand Up @@ -4822,7 +4822,7 @@ int pevent_strerror(struct pevent *pevent, enum pevent_errno errnum,
errnum >= __PEVENT_ERRNO__END)
return -1;

idx = errnum - __PEVENT_ERRNO__START;
idx = errnum - __PEVENT_ERRNO__START - 1;
msg = pevent_error_str[idx];

switch (errnum) {
Expand Down

0 comments on commit f63fe79

Please sign in to comment.