Skip to content

Commit

Permalink
staging/xgifb: fix addressing issues on platform with long physical a…
Browse files Browse the repository at this point in the history
…ddressing

Some platforms (e.g. ppc460ex) have 36-bit physical addressing, while
sizeof(unsigned long) == 4. Adapt xgifb driver to use phys_addr_t for
physical address variables instead of unsigned long.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Dmitry Eremin-Solenikov authored and Greg Kroah-Hartman committed Apr 10, 2012
1 parent 9a801f2 commit f650caa
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions drivers/staging/xgifb/XGI_main_26.c
Original file line number Diff line number Diff line change
Expand Up @@ -1910,8 +1910,8 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
xgifb_info->mmio_base = pci_resource_start(pdev, 1);
xgifb_info->mmio_size = pci_resource_len(pdev, 1);
xgifb_info->vga_base = pci_resource_start(pdev, 2) + 0x30;
pr_info("Relocate IO address: %lx [%08lx]\n",
(unsigned long)pci_resource_start(pdev, 2),
pr_info("Relocate IO address: %Lx [%08lx]\n",
(u64) pci_resource_start(pdev, 2),
xgifb_info->vga_base);

if (pci_enable_device(pdev)) {
Expand Down Expand Up @@ -2003,13 +2003,13 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
xgifb_info->mmio_vbase = ioremap(xgifb_info->mmio_base,
xgifb_info->mmio_size);

pr_info("Framebuffer at 0x%lx, mapped to 0x%p, size %dk\n",
xgifb_info->video_base,
pr_info("Framebuffer at 0x%Lx, mapped to 0x%p, size %dk\n",
(u64) xgifb_info->video_base,
xgifb_info->video_vbase,
xgifb_info->video_size / 1024);

pr_info("MMIO at 0x%lx, mapped to 0x%p, size %ldk\n",
xgifb_info->mmio_base, xgifb_info->mmio_vbase,
pr_info("MMIO at 0x%Lx, mapped to 0x%p, size %ldk\n",
(u64) xgifb_info->mmio_base, xgifb_info->mmio_vbase,
xgifb_info->mmio_size / 1024);

pci_set_drvdata(pdev, xgifb_info);
Expand Down
4 changes: 2 additions & 2 deletions drivers/staging/xgifb/XGIfb.h
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ struct xgifb_video_info {

int chip_id;
unsigned int video_size;
unsigned long video_base;
phys_addr_t video_base;
void __iomem *video_vbase;
unsigned long mmio_base;
phys_addr_t mmio_base;
unsigned long mmio_size;
void __iomem *mmio_vbase;
unsigned long vga_base;
Expand Down

0 comments on commit f650caa

Please sign in to comment.