Skip to content

Commit

Permalink
Merge tag 'stable/for-linus-3.11-rc3-tag' of git://git.kernel.org/pub…
Browse files Browse the repository at this point in the history
…/scm/linux/kernel/git/xen/tip

Pull Xen fixes from Konrad Rzeszutek Wilk:
 - Three fixes for ARM/ARM64 to either compile or not certain generic
   drivers
 - Fix for avoiding a potential deadlock when an user space event
   channel is destroyed.
 - Fix a workqueue resuming multiple times.

* tag 'stable/for-linus-3.11-rc3-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip:
  xen/tmem: do not allow XEN_TMEM on ARM64
  xen/evtchn: avoid a deadlock when unbinding an event channel
  xen/arm: enable PV control for ARM
  xen/arm64: Don't compile cpu hotplug
  xenbus: frontend resume cleanup
  • Loading branch information
Linus Torvalds committed Jul 31, 2013
2 parents 878d2cd + 741ddbc commit f66d95d
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 26 deletions.
2 changes: 1 addition & 1 deletion drivers/xen/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ config SWIOTLB_XEN

config XEN_TMEM
tristate
depends on !ARM
depends on !ARM && !ARM64
default m if (CLEANCACHE || FRONTSWAP)
help
Shim to interface in-kernel Transcendent Memory hooks
Expand Down
5 changes: 2 additions & 3 deletions drivers/xen/Makefile
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
ifneq ($(CONFIG_ARM),y)
obj-y += manage.o
ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
endif
obj-$(CONFIG_X86) += fallback.o
obj-y += grant-table.o features.o events.o balloon.o
obj-y += grant-table.o features.o events.o balloon.o manage.o
obj-y += xenbus/

nostackp := $(call cc-option, -fno-stack-protector)
Expand Down
21 changes: 2 additions & 19 deletions drivers/xen/evtchn.c
Original file line number Diff line number Diff line change
Expand Up @@ -379,18 +379,12 @@ static long evtchn_ioctl(struct file *file,
if (unbind.port >= NR_EVENT_CHANNELS)
break;

spin_lock_irq(&port_user_lock);

rc = -ENOTCONN;
if (get_port_user(unbind.port) != u) {
spin_unlock_irq(&port_user_lock);
if (get_port_user(unbind.port) != u)
break;
}

disable_irq(irq_from_evtchn(unbind.port));

spin_unlock_irq(&port_user_lock);

evtchn_unbind_from_user(u, unbind.port);

rc = 0;
Expand Down Expand Up @@ -490,26 +484,15 @@ static int evtchn_release(struct inode *inode, struct file *filp)
int i;
struct per_user_data *u = filp->private_data;

spin_lock_irq(&port_user_lock);

free_page((unsigned long)u->ring);

for (i = 0; i < NR_EVENT_CHANNELS; i++) {
if (get_port_user(i) != u)
continue;

disable_irq(irq_from_evtchn(i));
}

spin_unlock_irq(&port_user_lock);

for (i = 0; i < NR_EVENT_CHANNELS; i++) {
if (get_port_user(i) != u)
continue;

evtchn_unbind_from_user(get_port_user(i), i);
}

free_page((unsigned long)u->ring);
kfree(u->name);
kfree(u);

Expand Down
19 changes: 16 additions & 3 deletions drivers/xen/xenbus/xenbus_probe_frontend.c
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ static int xenbus_frontend_dev_resume(struct device *dev)
return -EFAULT;
}

INIT_WORK(&xdev->work, xenbus_frontend_delayed_resume);
queue_work(xenbus_frontend_wq, &xdev->work);

return 0;
Expand All @@ -124,6 +123,16 @@ static int xenbus_frontend_dev_resume(struct device *dev)
return xenbus_dev_resume(dev);
}

static int xenbus_frontend_dev_probe(struct device *dev)
{
if (xen_store_domain_type == XS_LOCAL) {
struct xenbus_device *xdev = to_xenbus_device(dev);
INIT_WORK(&xdev->work, xenbus_frontend_delayed_resume);
}

return xenbus_dev_probe(dev);
}

static const struct dev_pm_ops xenbus_pm_ops = {
.suspend = xenbus_dev_suspend,
.resume = xenbus_frontend_dev_resume,
Expand All @@ -142,7 +151,7 @@ static struct xen_bus_type xenbus_frontend = {
.name = "xen",
.match = xenbus_match,
.uevent = xenbus_uevent_frontend,
.probe = xenbus_dev_probe,
.probe = xenbus_frontend_dev_probe,
.remove = xenbus_dev_remove,
.shutdown = xenbus_dev_shutdown,
.dev_attrs = xenbus_dev_attrs,
Expand Down Expand Up @@ -474,7 +483,11 @@ static int __init xenbus_probe_frontend_init(void)

register_xenstore_notifier(&xenstore_notifier);

xenbus_frontend_wq = create_workqueue("xenbus_frontend");
if (xen_store_domain_type == XS_LOCAL) {
xenbus_frontend_wq = create_workqueue("xenbus_frontend");
if (!xenbus_frontend_wq)
pr_warn("create xenbus frontend workqueue failed, S3 resume is likely to fail\n");
}

return 0;
}
Expand Down

0 comments on commit f66d95d

Please sign in to comment.