Skip to content

Commit

Permalink
Staging: hv: Cleanup blkvsc_remove()
Browse files Browse the repository at this point in the history
The function storvsc_dev_remove() already deals with draining of
the outstanding I/O. Cleanup blkvsc_remove() keeping this in mind.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
K. Y. Srinivasan authored and Greg Kroah-Hartman committed May 11, 2011
1 parent 19fc2f2 commit f670f82
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions drivers/staging/hv/blkvsc_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -538,11 +538,6 @@ static int blkvsc_remove(struct hv_device *dev)
struct block_device_context *blkdev = dev_get_drvdata(&dev->device);
unsigned long flags;

/*
* Call to the vsc driver to let it know that the device is being
* removed
*/
storvsc_dev_remove(dev);

/* Get to a known state */
spin_lock_irqsave(&blkdev->lock, flags);
Expand All @@ -555,17 +550,16 @@ static int blkvsc_remove(struct hv_device *dev)

spin_unlock_irqrestore(&blkdev->lock, flags);

while (blkdev->num_outstanding_reqs) {
DPRINT_INFO(STORVSC, "waiting for %d requests to complete...",
blkdev->num_outstanding_reqs);
udelay(100);
}


blkvsc_do_operation(blkdev, DO_FLUSH);

blk_cleanup_queue(blkdev->gd->queue);

/*
* Call to the vsc driver to let it know that the device is being
* removed
*/
storvsc_dev_remove(dev);

del_gendisk(blkdev->gd);

kmem_cache_destroy(blkdev->request_pool);
Expand Down

0 comments on commit f670f82

Please sign in to comment.