Skip to content

Commit

Permalink
[PATCH] device-mapper multipath: Barriers not supported
Browse files Browse the repository at this point in the history
dm multipath will report barriers as not supported with this patch.

Signed-off-by: Lars Marowsky-Bree <lmb@suse.de>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Alasdair G Kergon authored and Linus Torvalds committed Jul 12, 2005
1 parent 3f603ed commit f6a80ea
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
6 changes: 6 additions & 0 deletions drivers/md/dm-mpath.c
Original file line number Diff line number Diff line change
Expand Up @@ -765,6 +765,9 @@ static int multipath_map(struct dm_target *ti, struct bio *bio,
struct mpath_io *mpio;
struct multipath *m = (struct multipath *) ti->private;

if (bio_barrier(bio))
return -EOPNOTSUPP;

mpio = mempool_alloc(m->mpio_pool, GFP_NOIO);
dm_bio_record(&mpio->details, bio);

Expand Down Expand Up @@ -988,6 +991,9 @@ static int do_end_io(struct multipath *m, struct bio *bio,
if ((error == -EWOULDBLOCK) && bio_rw_ahead(bio))
return error;

if (error == -EOPNOTSUPP)
return error;

spin_lock(&m->lock);
if (!m->nr_valid_paths) {
if (!m->queue_if_no_path || m->suspended) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/md/dm-snap.c
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ static int snapshot_map(struct dm_target *ti, struct bio *bio,

/* Full snapshots are not usable */
if (!s->valid)
return -1;
return -EIO;

/*
* Write to snapshot - higher level takes care of RW/RO
Expand Down
2 changes: 1 addition & 1 deletion drivers/md/dm.c
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ static void __map_bio(struct dm_target *ti, struct bio *clone,
/* error the io and bail out */
struct dm_io *io = tio->io;
free_tio(tio->io->md, tio);
dec_pending(io, -EIO);
dec_pending(io, r);
bio_put(clone);
}
}
Expand Down

0 comments on commit f6a80ea

Please sign in to comment.