Skip to content

Commit

Permalink
xen: call clock resume notifier on all CPUs
Browse files Browse the repository at this point in the history
tick_resume() is never called on secondary processors. Presumably this
is because they are offlined for suspend on native and so this is
normally taken care of in the CPU onlining path. Under Xen we keep all
CPUs online over a suspend.

This patch papers over the issue for me but I will investigate a more
generic, less hacky, way of doing to the same.

tick_suspend is also only called on the boot CPU which I presume should
be fixed too.

Signed-off-by: Ian Campbell <Ian.Campbell@citrix.com>
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Stable Kernel <stable@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Ian Campbell authored and Jeremy Fitzhardinge committed Dec 3, 2009
1 parent 6aaf5d6 commit f6eafe3
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion arch/x86/xen/suspend.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include <linux/types.h>
#include <linux/clockchips.h>

#include <xen/interface/xen.h>
#include <xen/grant_table.h>
Expand Down Expand Up @@ -46,7 +47,19 @@ void xen_post_suspend(int suspend_cancelled)

}

static void xen_vcpu_notify_restore(void *data)
{
unsigned long reason = (unsigned long)data;

/* Boot processor notified via generic timekeeping_resume() */
if ( smp_processor_id() == 0)
return;

clockevents_notify(reason, NULL);
}

void xen_arch_resume(void)
{
/* nothing */
smp_call_function(xen_vcpu_notify_restore,
(void *)CLOCK_EVT_NOTIFY_RESUME, 1);
}

0 comments on commit f6eafe3

Please sign in to comment.