Skip to content

Commit

Permalink
[UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list
Browse files Browse the repository at this point in the history
IFF_ALLMULTI is an indication from the network stack to the driver
to disable multicast filters, drivers should never set it directly.

Since the UML networking device doesn't have any filtering capabilites,
it doesn't the set_multicast_list function at all, it is kept so userspace
can still issue SIOCADDMULTI/SIOCDELMULTI ioctls however.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Patrick McHardy authored and David S. Miller committed Mar 26, 2008
1 parent 0ed21b3 commit f70c176
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions arch/um/drivers/net_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -256,11 +256,7 @@ static struct net_device_stats *uml_net_get_stats(struct net_device *dev)

static void uml_net_set_multicast_list(struct net_device *dev)
{
if (dev->flags & IFF_PROMISC)
return;
else if (dev->mc_count)
dev->flags |= IFF_ALLMULTI;
else dev->flags &= ~IFF_ALLMULTI;
return;
}

static void uml_net_tx_timeout(struct net_device *dev)
Expand Down

0 comments on commit f70c176

Please sign in to comment.