---

yaml
---
r: 43765
b: refs/heads/master
c: f1729c2
h: refs/heads/master
i:
  43763: 48f99b9
v: v3

[refs]

@@ -1,2 +1,2 @@
 ---
-refs/heads/master: a124c28ef85d9b780c418b2c5d8f01cd6a06ff3e
+refs/heads/master: f1729c28a37e4f11ea5d9f468ab26adadb1aadab

trunk/lib/fault-inject.c

@@ -142,9 +142,6 @@ bool should_fail(struct fault_attr *attr, ssize_t size)
 	if (attr->task_filter && !fail_task(attr, current))
 		return false;
 
-	if (!fail_stacktrace(attr))
-		return false;
-
 	if (atomic_read(&attr->times) == 0)
 		return false;
 
@@ -159,12 +156,12 @@ bool should_fail(struct fault_attr *attr, ssize_t size)
 			return false;
 	}
 
-	if (attr->probability > random32() % 100)
-		goto fail;
+	if (attr->probability <= random32() % 100)
+		return false;
 
-	return false;
+	if (!fail_stacktrace(attr))
+		return false;
 
-fail:
 	fail_dump(attr);
 
 	if (atomic_read(&attr->times) != -1)