Skip to content

Commit

Permalink
ARM: OMAP2+: sparse: add missing static declaration
Browse files Browse the repository at this point in the history
Add missing static declaration for file local variables.
This fixes sparse warnings of type:

arch/arm/mach-omap2/omap_hwmod_81xx_data.c:491:26: warning: symbol 'dm81xx_alwon_l3_slow__gpmc' was not declared. Should it be static?

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
  • Loading branch information
Sekhar Nori authored and Paul Walmsley committed Jul 16, 2015
1 parent aaf2c0f commit f734a9b
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 23 deletions.
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/omap-mpuss-lowpower.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ static void dummy_cpu_resume(void)
static void dummy_scu_prepare(unsigned int cpu_id, unsigned int cpu_state)
{}

struct cpu_pm_ops omap_pm_ops = {
static struct cpu_pm_ops omap_pm_ops = {
.finish_suspend = default_finish_suspend,
.resume = dummy_cpu_resume,
.scu_prepare = dummy_scu_prepare,
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#include "prm-regbits-24xx.h"
#include "wd_timer.h"

struct omap_hwmod_dma_info omap2xxx_dss_sdma_chs[] = {
static struct omap_hwmod_dma_info omap2xxx_dss_sdma_chs[] = {
{ .name = "dispc", .dma_req = 5 },
{ .dma_req = -1, },
};
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/omap_hwmod_43xx_data.c
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ static struct omap_hwmod am43xx_dss_core_hwmod = {

/* dispc */

struct omap_dss_dispc_dev_attr am43xx_dss_dispc_dev_attr = {
static struct omap_dss_dispc_dev_attr am43xx_dss_dispc_dev_attr = {
.manager_count = 1,
.has_framedonetv_irq = 0
};
Expand Down
34 changes: 17 additions & 17 deletions arch/arm/mach-omap2/omap_hwmod_81xx_data.c
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ static struct omap_hwmod dm81xx_gpmc_hwmod = {
},
};

struct omap_hwmod_ocp_if dm81xx_alwon_l3_slow__gpmc = {
static struct omap_hwmod_ocp_if dm81xx_alwon_l3_slow__gpmc = {
.master = &dm816x_alwon_l3_slow_hwmod,
.slave = &dm81xx_gpmc_hwmod,
.user = OCP_USER_MPU,
Expand Down Expand Up @@ -729,7 +729,7 @@ static struct omap_hwmod_class dm816x_mdio_hwmod_class = {
.sysc = &dm816x_emac_sysc,
};

struct omap_hwmod dm816x_emac0_mdio_hwmod = {
static struct omap_hwmod dm816x_emac0_mdio_hwmod = {
.name = "davinci_mdio",
.class = &dm816x_mdio_hwmod_class,
.clkdm_name = "alwon_ethernet_clkdm",
Expand All @@ -747,7 +747,7 @@ struct omap_hwmod dm816x_emac0_mdio_hwmod = {
},
};

struct omap_hwmod_ocp_if dm816x_emac0__mdio = {
static struct omap_hwmod_ocp_if dm816x_emac0__mdio = {
.master = &dm816x_l4_hs_hwmod,
.slave = &dm816x_emac0_mdio_hwmod,
.user = OCP_USER_MPU,
Expand Down Expand Up @@ -902,7 +902,7 @@ static struct omap_hwmod_class dm816x_tpcc_hwmod_class = {
.name = "tpcc",
};

struct omap_hwmod dm816x_tpcc_hwmod = {
static struct omap_hwmod dm816x_tpcc_hwmod = {
.name = "tpcc",
.class = &dm816x_tpcc_hwmod_class,
.clkdm_name = "alwon_l3s_clkdm",
Expand All @@ -915,7 +915,7 @@ struct omap_hwmod dm816x_tpcc_hwmod = {
},
};

struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tpcc = {
static struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tpcc = {
.master = &dm816x_alwon_l3_fast_hwmod,
.slave = &dm816x_tpcc_hwmod,
.clk = "sysclk4_ck",
Expand All @@ -935,7 +935,7 @@ static struct omap_hwmod_class dm816x_tptc0_hwmod_class = {
.name = "tptc0",
};

struct omap_hwmod dm816x_tptc0_hwmod = {
static struct omap_hwmod dm816x_tptc0_hwmod = {
.name = "tptc0",
.class = &dm816x_tptc0_hwmod_class,
.clkdm_name = "alwon_l3s_clkdm",
Expand All @@ -948,15 +948,15 @@ struct omap_hwmod dm816x_tptc0_hwmod = {
},
};

struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tptc0 = {
static struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tptc0 = {
.master = &dm816x_alwon_l3_fast_hwmod,
.slave = &dm816x_tptc0_hwmod,
.clk = "sysclk4_ck",
.addr = dm816x_tptc0_addr_space,
.user = OCP_USER_MPU,
};

struct omap_hwmod_ocp_if dm816x_tptc0__alwon_l3_fast = {
static struct omap_hwmod_ocp_if dm816x_tptc0__alwon_l3_fast = {
.master = &dm816x_tptc0_hwmod,
.slave = &dm816x_alwon_l3_fast_hwmod,
.clk = "sysclk4_ck",
Expand All @@ -977,7 +977,7 @@ static struct omap_hwmod_class dm816x_tptc1_hwmod_class = {
.name = "tptc1",
};

struct omap_hwmod dm816x_tptc1_hwmod = {
static struct omap_hwmod dm816x_tptc1_hwmod = {
.name = "tptc1",
.class = &dm816x_tptc1_hwmod_class,
.clkdm_name = "alwon_l3s_clkdm",
Expand All @@ -990,15 +990,15 @@ struct omap_hwmod dm816x_tptc1_hwmod = {
},
};

struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tptc1 = {
static struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tptc1 = {
.master = &dm816x_alwon_l3_fast_hwmod,
.slave = &dm816x_tptc1_hwmod,
.clk = "sysclk4_ck",
.addr = dm816x_tptc1_addr_space,
.user = OCP_USER_MPU,
};

struct omap_hwmod_ocp_if dm816x_tptc1__alwon_l3_fast = {
static struct omap_hwmod_ocp_if dm816x_tptc1__alwon_l3_fast = {
.master = &dm816x_tptc1_hwmod,
.slave = &dm816x_alwon_l3_fast_hwmod,
.clk = "sysclk4_ck",
Expand All @@ -1019,7 +1019,7 @@ static struct omap_hwmod_class dm816x_tptc2_hwmod_class = {
.name = "tptc2",
};

struct omap_hwmod dm816x_tptc2_hwmod = {
static struct omap_hwmod dm816x_tptc2_hwmod = {
.name = "tptc2",
.class = &dm816x_tptc2_hwmod_class,
.clkdm_name = "alwon_l3s_clkdm",
Expand All @@ -1032,15 +1032,15 @@ struct omap_hwmod dm816x_tptc2_hwmod = {
},
};

struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tptc2 = {
static struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tptc2 = {
.master = &dm816x_alwon_l3_fast_hwmod,
.slave = &dm816x_tptc2_hwmod,
.clk = "sysclk4_ck",
.addr = dm816x_tptc2_addr_space,
.user = OCP_USER_MPU,
};

struct omap_hwmod_ocp_if dm816x_tptc2__alwon_l3_fast = {
static struct omap_hwmod_ocp_if dm816x_tptc2__alwon_l3_fast = {
.master = &dm816x_tptc2_hwmod,
.slave = &dm816x_alwon_l3_fast_hwmod,
.clk = "sysclk4_ck",
Expand All @@ -1061,7 +1061,7 @@ static struct omap_hwmod_class dm816x_tptc3_hwmod_class = {
.name = "tptc3",
};

struct omap_hwmod dm816x_tptc3_hwmod = {
static struct omap_hwmod dm816x_tptc3_hwmod = {
.name = "tptc3",
.class = &dm816x_tptc3_hwmod_class,
.clkdm_name = "alwon_l3s_clkdm",
Expand All @@ -1074,15 +1074,15 @@ struct omap_hwmod dm816x_tptc3_hwmod = {
},
};

struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tptc3 = {
static struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tptc3 = {
.master = &dm816x_alwon_l3_fast_hwmod,
.slave = &dm816x_tptc3_hwmod,
.clk = "sysclk4_ck",
.addr = dm816x_tptc3_addr_space,
.user = OCP_USER_MPU,
};

struct omap_hwmod_ocp_if dm816x_tptc3__alwon_l3_fast = {
static struct omap_hwmod_ocp_if dm816x_tptc3__alwon_l3_fast = {
.master = &dm816x_tptc3_hwmod,
.slave = &dm816x_alwon_l3_fast_hwmod,
.clk = "sysclk4_ck",
Expand Down
6 changes: 3 additions & 3 deletions arch/arm/mach-omap2/pdata-quirks.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ struct pdata_init {
void (*fn)(void);
};

struct of_dev_auxdata omap_auxdata_lookup[];
static struct of_dev_auxdata omap_auxdata_lookup[];
static struct twl4030_gpio_platform_data twl_gpio_auxdata;

#ifdef CONFIG_MACH_NOKIA_N8X0
Expand Down Expand Up @@ -128,7 +128,7 @@ static void __init omap3_sbc_t3530_legacy_init(void)
omap3_sbc_t3x_usb_hub_init(167, "sb-t35 usb hub");
}

struct ti_st_plat_data wilink_pdata = {
static struct ti_st_plat_data wilink_pdata = {
.nshutdown_gpio = 137,
.dev_name = "/dev/ttyO1",
.flow_cntrl = 1,
Expand Down Expand Up @@ -323,7 +323,7 @@ static struct pdata_init auxdata_quirks[] __initdata = {
{ /* sentinel */ },
};

struct of_dev_auxdata omap_auxdata_lookup[] __initdata = {
static struct of_dev_auxdata omap_auxdata_lookup[] __initdata = {
#ifdef CONFIG_MACH_NOKIA_N8X0
OF_DEV_AUXDATA("ti,omap2420-mmc", 0x4809c000, "mmci-omap.0", NULL),
OF_DEV_AUXDATA("menelaus", 0x72, "1-0072", &n8x0_menelaus_platform_data),
Expand Down

0 comments on commit f734a9b

Please sign in to comment.