Skip to content

Commit

Permalink
Drivers: hv: balloon: Support 2M page allocations for ballooning
Browse files Browse the repository at this point in the history
On Hyper-V it will be very efficient to use 2M allocations in the guest as this
makes the ballooning protocol with the host that much more efficient. Hyper-V
uses page ranges (start pfn : number of pages) to specify memory being moved
around and with 2M pages this encoding can be very efficient. However, when
memory is returned to the guest, the host does not guarantee any granularity.
To deal with this issue, split the page soon after a successful 2M allocation
so that this memory can potentially be freed as 4K pages.

If 2M allocations fail, we revert to 4K allocations.

In this version of the patch, based on the feedback from Michal Hocko
<mhocko@suse.cz>, I have added some additional commentary to the patch
description.

Cc: Michal Hocko <mhocko@suse.cz>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
K. Y. Srinivasan authored and Greg Kroah-Hartman committed Mar 29, 2013
1 parent 5853ff2 commit f766dc1
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions drivers/hv/hv_balloon.c
Original file line number Diff line number Diff line change
Expand Up @@ -1004,6 +1004,14 @@ static int alloc_balloon_pages(struct hv_dynmem_device *dm, int num_pages,

dm->num_pages_ballooned += alloc_unit;

/*
* If we allocatted 2M pages; split them so we
* can free them in any order we get.
*/

if (alloc_unit != 1)
split_page(pg, get_order(alloc_unit << PAGE_SHIFT));

bl_resp->range_count++;
bl_resp->range_array[i].finfo.start_page =
page_to_pfn(pg);
Expand All @@ -1030,9 +1038,10 @@ static void balloon_up(struct work_struct *dummy)


/*
* Currently, we only support 4k allocations.
* We will attempt 2M allocations. However, if we fail to
* allocate 2M chunks, we will go back to 4k allocations.
*/
alloc_unit = 1;
alloc_unit = 512;

while (!done) {
bl_resp = (struct dm_balloon_response *)send_buffer;
Expand All @@ -1048,6 +1057,11 @@ static void balloon_up(struct work_struct *dummy)
bl_resp, alloc_unit,
&alloc_error);

if ((alloc_error) && (alloc_unit != 1)) {
alloc_unit = 1;
continue;
}

if ((alloc_error) || (num_ballooned == num_pages)) {
bl_resp->more_pages = 0;
done = true;
Expand Down

0 comments on commit f766dc1

Please sign in to comment.