Skip to content

Commit

Permalink
bq27x00_battery: Fix error return code
Browse files Browse the repository at this point in the history
Initialize return variable before exiting on an error path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
  • Loading branch information
Julia Lawall authored and Anton Vorontsov committed Aug 23, 2012
1 parent d294165 commit f776099
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/power/bq27x00_battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -814,7 +814,8 @@ static int bq27x00_battery_probe(struct i2c_client *client,
di->bat.name = name;
di->bus.read = &bq27x00_read_i2c;

if (bq27x00_powersupply_init(di))
retval = bq27x00_powersupply_init(di);
if (retval)
goto batt_failed_3;

i2c_set_clientdata(client, di);
Expand Down

0 comments on commit f776099

Please sign in to comment.