Skip to content

Commit

Permalink
ASoC: alc56(23|32): fix undefined return value of probing code
Browse files Browse the repository at this point in the history
Commit 5d6be5a ("ASoC: codec: Simplify ASoC probe code.") left variable
'ret', whose value is returned, uninitialized. Since it is not used
otherwise, remove it.

Signed-off-by: Christoph Jaeger <christophjaeger@linux.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Christoph Jaeger authored and Mark Brown committed Apr 4, 2014
1 parent c159a85 commit f78b1e0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions sound/soc/codecs/alc5623.c
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,6 @@ static int alc5623_probe(struct snd_soc_codec *codec)
{
struct alc5623_priv *alc5623 = snd_soc_codec_get_drvdata(codec);
struct snd_soc_dapm_context *dapm = &codec->dapm;
int ret;

alc5623_reset(codec);

Expand Down Expand Up @@ -961,7 +960,7 @@ static int alc5623_probe(struct snd_soc_codec *codec)
return -EINVAL;
}

return ret;
return 0;
}

/* power down chip */
Expand Down
3 changes: 1 addition & 2 deletions sound/soc/codecs/alc5632.c
Original file line number Diff line number Diff line change
Expand Up @@ -1061,7 +1061,6 @@ static int alc5632_resume(struct snd_soc_codec *codec)
static int alc5632_probe(struct snd_soc_codec *codec)
{
struct alc5632_priv *alc5632 = snd_soc_codec_get_drvdata(codec);
int ret;

/* power on device */
alc5632_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
Expand All @@ -1075,7 +1074,7 @@ static int alc5632_probe(struct snd_soc_codec *codec)
return -EINVAL;
}

return ret;
return 0;
}

/* power down chip */
Expand Down

0 comments on commit f78b1e0

Please sign in to comment.