Skip to content

Commit

Permalink
[media] ov9640: use macro to request OmniVision OV9640 sensor private…
Browse files Browse the repository at this point in the history
… data

This cleanup patch creates macro to request OmniVision OV9640 private
data, which increases readability.

Signed-off-by: David Cohen <dacohen@gmail.com>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
David Cohen authored and Mauro Carvalho Chehab committed Dec 31, 2010
1 parent 9804ed9 commit f7b74f7
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions drivers/media/video/ov9640.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@

#include "ov9640.h"

#define to_ov9640_sensor(sd) container_of(sd, struct ov9640_priv, subdev)

/* default register setup */
static const struct ov9640_reg ov9640_regs_dflt[] = {
{ OV9640_COM5, OV9640_COM5_SYSCLK | OV9640_COM5_LONGEXP },
Expand Down Expand Up @@ -308,9 +310,7 @@ static unsigned long ov9640_query_bus_param(struct soc_camera_device *icd)
/* Get status of additional camera capabilities */
static int ov9640_g_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
{
struct i2c_client *client = v4l2_get_subdevdata(sd);
struct ov9640_priv *priv = container_of(i2c_get_clientdata(client),
struct ov9640_priv, subdev);
struct ov9640_priv *priv = to_ov9640_sensor(sd);

switch (ctrl->id) {
case V4L2_CID_VFLIP:
Expand All @@ -327,8 +327,7 @@ static int ov9640_g_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
static int ov9640_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
{
struct i2c_client *client = v4l2_get_subdevdata(sd);
struct ov9640_priv *priv = container_of(i2c_get_clientdata(client),
struct ov9640_priv, subdev);
struct ov9640_priv *priv = to_ov9640_sensor(sd);

int ret = 0;

Expand Down Expand Up @@ -360,9 +359,7 @@ static int ov9640_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
static int ov9640_g_chip_ident(struct v4l2_subdev *sd,
struct v4l2_dbg_chip_ident *id)
{
struct i2c_client *client = v4l2_get_subdevdata(sd);
struct ov9640_priv *priv = container_of(i2c_get_clientdata(client),
struct ov9640_priv, subdev);
struct ov9640_priv *priv = to_ov9640_sensor(sd);

id->ident = priv->model;
id->revision = priv->revision;
Expand Down

0 comments on commit f7b74f7

Please sign in to comment.