Skip to content

Commit

Permalink
drivers/net/ethernet/ibm/emac/mal.c: use WARN
Browse files Browse the repository at this point in the history
Use WARN rather than printk followed by WARN_ON(1), for conciseness.

A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression list es;
@@

-printk(
+WARN(1,
  es);
-WARN_ON(1);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julia Lawall authored and David S. Miller committed Nov 3, 2012
1 parent bb263e1 commit f7c3f96
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/net/ethernet/ibm/emac/mal.c
Original file line number Diff line number Diff line change
Expand Up @@ -738,13 +738,11 @@ static int __devexit mal_remove(struct platform_device *ofdev)
/* Synchronize with scheduled polling */
napi_disable(&mal->napi);

if (!list_empty(&mal->list)) {
if (!list_empty(&mal->list))
/* This is *very* bad */
printk(KERN_EMERG
WARN(1, KERN_EMERG
"mal%d: commac list is not empty on remove!\n",
mal->index);
WARN_ON(1);
}

dev_set_drvdata(&ofdev->dev, NULL);

Expand Down

0 comments on commit f7c3f96

Please sign in to comment.