Skip to content

Commit

Permalink
ext4: Use is_power_of_2() for clarity
Browse files Browse the repository at this point in the history
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  • Loading branch information
Theodore Ts'o committed Apr 25, 2009
1 parent c5ca7c7 commit f7c4395
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions fs/ext4/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1483,7 +1483,7 @@ static int parse_options(char *options, struct super_block *sb,
return 0;
if (option < 0 || option > (1 << 30))
return 0;
if (option & (option - 1)) {
if (!is_power_of_2(option)) {
printk(KERN_ERR "EXT4-fs: inode_readahead_blks"
" must be a power of 2\n");
return 0;
Expand Down Expand Up @@ -2101,8 +2101,7 @@ static ssize_t inode_readahead_blks_store(struct ext4_attr *a,
if (parse_strtoul(buf, 0x40000000, &t))
return -EINVAL;

/* inode_readahead_blks must be a power of 2 */
if (t & (t-1))
if (!is_power_of_2(t))
return -EINVAL;

sbi->s_inode_readahead_blks = t;
Expand Down

0 comments on commit f7c4395

Please sign in to comment.