Skip to content

Commit

Permalink
PNPACPI: pnpacpi_encode_ext_irq() wrongly set "irq" instead of "exten…
Browse files Browse the repository at this point in the history
…ded_irq"

pnpacpi_encode_ext_irq() should set resource->data.extended_irq, not
resource->data.irq.

This has been wrong since at least 2.6.12.  I haven't seen any bug
reports, but it's clearly incorrect.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Bjorn Helgaas authored and Len Brown committed Apr 29, 2008
1 parent 6bf2aab commit f7e8466
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/pnp/pnpacpi/rsparser.c
Original file line number Diff line number Diff line change
Expand Up @@ -820,9 +820,9 @@ static void pnpacpi_encode_ext_irq(struct acpi_resource *resource,
resource->data.extended_irq.triggering = triggering;
resource->data.extended_irq.polarity = polarity;
if (triggering == ACPI_EDGE_SENSITIVE)
resource->data.irq.sharable = ACPI_EXCLUSIVE;
resource->data.extended_irq.sharable = ACPI_EXCLUSIVE;
else
resource->data.irq.sharable = ACPI_SHARED;
resource->data.extended_irq.sharable = ACPI_SHARED;
resource->data.extended_irq.interrupt_count = 1;
resource->data.extended_irq.interrupts[0] = p->start;
}
Expand Down

0 comments on commit f7e8466

Please sign in to comment.