Skip to content

Commit

Permalink
wext: remove seq_start/stop sparse annotations
Browse files Browse the repository at this point in the history
Even though they are true, they cause sparse to complain
because it doesn't see the __acquires(dev_base_lock) on
dev_seq_start() because it is only added to the function
in net/core/dev.c, not the header file. To keep track of
the nesting correctly we should probably annotate those
functions publically, but for now let's just remove the
annotation I added to wext.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Johannes Berg authored and John W. Linville committed May 13, 2009
1 parent faa8fdc commit f7eef35
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions net/wireless/wext.c
Original file line number Diff line number Diff line change
Expand Up @@ -650,14 +650,12 @@ static int wireless_seq_show(struct seq_file *seq, void *v)
}

static void *wireless_dev_seq_start(struct seq_file *seq, loff_t *pos)
__acquires(dev_base_lock)
{
rtnl_lock();
return dev_seq_start(seq, pos);
}

static void wireless_dev_seq_stop(struct seq_file *seq, void *v)
__releases(dev_base_lock)
{
dev_seq_stop(seq, v);
rtnl_unlock();
Expand Down

0 comments on commit f7eef35

Please sign in to comment.