Skip to content

Commit

Permalink
cnic: Free UIO rings when the device is closed.
Browse files Browse the repository at this point in the history
This will free up unneeded memory.

Reviewed-by: Eddie Wai <eddie.wai@broadcom.com>
Reviewed-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Michael Chan authored and David S. Miller committed Sep 10, 2012
1 parent 74dd0c4 commit f81b0ac
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/net/ethernet/broadcom/cnic.c
Original file line number Diff line number Diff line change
Expand Up @@ -868,6 +868,8 @@ static void cnic_free_resc(struct cnic_dev *dev)
if (udev) {
udev->dev = NULL;
cp->udev = NULL;
if (udev->uio_dev == -1)
__cnic_free_uio_rings(udev);
}

cnic_free_context(dev);
Expand Down Expand Up @@ -1039,6 +1041,11 @@ static int cnic_alloc_uio_rings(struct cnic_dev *dev, int pages)
list_for_each_entry(udev, &cnic_udev_list, list) {
if (udev->pdev == dev->pcidev) {
udev->dev = dev;
if (__cnic_alloc_uio_rings(udev, pages)) {
udev->dev = NULL;
read_unlock(&cnic_dev_lock);
return -ENOMEM;
}
cp->udev = udev;
read_unlock(&cnic_dev_lock);
return 0;
Expand Down

0 comments on commit f81b0ac

Please sign in to comment.