Skip to content

Commit

Permalink
i2c-nomadik: fixup bus delays
Browse files Browse the repository at this point in the history
We were missing a transfer delay in one execution path leading to
hangs and the bus timeout was too low leading to errors under
stress tests.

Acked-by: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>
Signed-off-by: Sundar R Iyer <sundar.iyer@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
  • Loading branch information
Linus Walleij authored and Ben Dooks committed Oct 25, 2010
1 parent 5680bc6 commit f868fc3
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/i2c/busses/i2c-nomadik.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@
/* maximum threshold value */
#define MAX_I2C_FIFO_THRESHOLD 15

/* per-transfer delay, required for the hardware to stabilize */
#define I2C_DELAY 150

enum i2c_status {
I2C_NOP,
I2C_ON_GOING,
Expand All @@ -118,7 +121,7 @@ enum i2c_operation {
};

/* controller response timeout in ms */
#define I2C_TIMEOUT_MS 500
#define I2C_TIMEOUT_MS 2000

/**
* struct i2c_nmk_client - client specific data
Expand Down Expand Up @@ -267,6 +270,7 @@ static int init_hw(struct nmk_i2c_dev *dev)

clk_disable(dev->clk);

udelay(I2C_DELAY);
return 0;
}

Expand Down Expand Up @@ -599,7 +603,7 @@ static int nmk_i2c_xfer(struct i2c_adapter *i2c_adap,
clk_disable(dev->clk);
return status;
}
mdelay(1);
udelay(I2C_DELAY);
}
clk_disable(dev->clk);

Expand Down

0 comments on commit f868fc3

Please sign in to comment.