Skip to content

Commit

Permalink
video: irq: Remove IRQF_DISABLED
Browse files Browse the repository at this point in the history 
Since commit [e58aa3d: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50:
genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Acked-by: David Brown <davidb@codeaurora.org>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
  • Loading branch information
Yong Zhang authored and Florian Tobias Schandinat committed Oct 3, 2011
1 parent 261e767 commit f8798cc
Show file tree
Hide file tree
Showing 18 changed files with 19 additions and 20 deletions.
2 changes: 1 addition & 1 deletion drivers/video/au1200fb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1673,7 +1673,7 @@ static int __devinit au1200fb_drv_probe(struct platform_device *dev)
/* Now hook interrupt too */
irq = platform_get_irq(dev, 0);
ret = request_irq(irq, au1200fb_handle_irq,
IRQF_DISABLED | IRQF_SHARED, "lcd", (void *)dev);
IRQF_SHARED, "lcd", (void *)dev);
if (ret) {
print_err("fail to request interrupt line %d (err: %d)",
irq, ret);
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/bf54x-lq043fb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ static int __devinit bfin_bf54x_probe(struct platform_device *pdev)
goto out7;
}

if (request_irq(info->irq, bfin_bf54x_irq_error, IRQF_DISABLED,
if (request_irq(info->irq, bfin_bf54x_irq_error, 0,
"PPI ERROR", info) < 0) {
printk(KERN_ERR DRIVER_NAME
": unable to request PPI ERROR IRQ\n");
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/bfin-lq035q1-fb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ static int __devinit bfin_lq035q1_probe(struct platform_device *pdev)
goto out7;
}

ret = request_irq(info->irq, bfin_lq035q1_irq_error, IRQF_DISABLED,
ret = request_irq(info->irq, bfin_lq035q1_irq_error, 0,
DRIVER_NAME" PPI ERROR", info);
if (ret < 0) {
dev_err(&pdev->dev, "unable to request PPI ERROR IRQ\n");
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/bfin-t350mcqb-fb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ static int __devinit bfin_t350mcqb_probe(struct platform_device *pdev)
goto out7;
}

ret = request_irq(info->irq, bfin_t350mcqb_irq_error, IRQF_DISABLED,
ret = request_irq(info->irq, bfin_t350mcqb_irq_error, 0,
"PPI ERROR", info);
if (ret < 0) {
printk(KERN_ERR DRIVER_NAME
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/bfin_adv7393fb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ static int __devinit bfin_adv7393_fb_probe(struct i2c_client *client,
goto out_4;
}

if (request_irq(IRQ_PPI_ERROR, ppi_irq_error, IRQF_DISABLED,
if (request_irq(IRQ_PPI_ERROR, ppi_irq_error, 0,
"PPI ERROR", fbdev) < 0) {
dev_err(&client->dev, "unable to request PPI ERROR IRQ\n");
ret = -EFAULT;
Expand Down
4 changes: 2 additions & 2 deletions drivers/video/mb862xx/mb862xxfbdrv.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ static int __devinit of_platform_mb862xx_probe(struct platform_device *ofdev)
if (mb862xx_gdc_init(par))
goto io_unmap;

if (request_irq(par->irq, mb862xx_intr, IRQF_DISABLED,
if (request_irq(par->irq, mb862xx_intr, 0,
DRV_NAME, (void *)par)) {
dev_err(dev, "Cannot request irq\n");
goto io_unmap;
Expand Down Expand Up @@ -1073,7 +1073,7 @@ static int __devinit mb862xx_pci_probe(struct pci_dev *pdev,
if (mb862xx_pci_gdc_init(par))
goto io_unmap;

if (request_irq(par->irq, mb862xx_intr, IRQF_DISABLED | IRQF_SHARED,
if (request_irq(par->irq, mb862xx_intr, IRQF_SHARED,
DRV_NAME, (void *)par)) {
dev_err(dev, "Cannot request irq\n");
goto io_unmap;
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/msm/mddi.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ static int __devinit mddi_probe(struct platform_device *pdev)

mddi->int_enable = 0;
mddi_writel(mddi->int_enable, INTEN);
ret = request_irq(mddi->irq, mddi_isr, IRQF_DISABLED, "mddi",
ret = request_irq(mddi->irq, mddi_isr, 0, "mddi",
&mddi->client_data);
if (ret) {
printk(KERN_ERR "mddi: failed to request enable irq!\n");
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/msm/mdp.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ int mdp_probe(struct platform_device *pdev)
goto error_get_clk;
}

ret = request_irq(mdp->irq, mdp_isr, IRQF_DISABLED, "msm_mdp", mdp);
ret = request_irq(mdp->irq, mdp_isr, 0, "msm_mdp", mdp);
if (ret)
goto error_request_irq;
disable_irq(mdp->irq);
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/nuc900fb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ static int __devinit nuc900fb_probe(struct platform_device *pdev)
fbinfo->flags = FBINFO_FLAG_DEFAULT;
fbinfo->pseudo_palette = &fbi->pseudo_pal;

ret = request_irq(irq, nuc900fb_irqhandler, IRQF_DISABLED,
ret = request_irq(irq, nuc900fb_irqhandler, 0,
pdev->name, fbinfo);
if (ret) {
dev_err(&pdev->dev, "cannot register irq handler %d -err %d\n",
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/omap2/displays/panel-taal.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,7 @@ static int taal_probe(struct omap_dss_device *dssdev)
gpio_direction_input(gpio);

r = request_irq(gpio_to_irq(gpio), taal_te_isr,
IRQF_DISABLED | IRQF_TRIGGER_RISING,
IRQF_TRIGGER_RISING,
"taal vsync", dssdev);

if (r) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/ps3fb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1082,7 +1082,7 @@ static int __devinit ps3fb_probe(struct ps3_system_bus_device *dev)
}

retval = request_irq(ps3fb.irq_no, ps3fb_vsync_interrupt,
IRQF_DISABLED, DEVICE_NAME, &dev->core);
0, DEVICE_NAME, &dev->core);
if (retval) {
dev_err(&dev->core, "%s: request_irq failed %d\n", __func__,
retval);
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/pxa3xx-gcu.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ pxa3xx_gcu_probe(struct platform_device *dev)
}

ret = request_irq(irq, pxa3xx_gcu_handle_irq,
IRQF_DISABLED, DRV_NAME, priv);
0, DRV_NAME, priv);
if (ret) {
dev_err(&dev->dev, "request_irq failed\n");
ret = -EBUSY;
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/pxafb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2191,7 +2191,7 @@ static int __devinit pxafb_probe(struct platform_device *dev)
goto failed_free_mem;
}

ret = request_irq(irq, pxafb_handle_irq, IRQF_DISABLED, "LCD", fbi);
ret = request_irq(irq, pxafb_handle_irq, 0, "LCD", fbi);
if (ret) {
dev_err(&dev->dev, "request_irq failed: %d\n", ret);
ret = -EBUSY;
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/s3c2410fb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,7 @@ static int __devinit s3c24xxfb_probe(struct platform_device *pdev,
for (i = 0; i < 256; i++)
info->palette_buffer[i] = PALETTE_BUFF_CLEAR;

ret = request_irq(irq, s3c2410fb_irq, IRQF_DISABLED, pdev->name, info);
ret = request_irq(irq, s3c2410fb_irq, 0, pdev->name, info);
if (ret) {
dev_err(&pdev->dev, "cannot get irq %d - err %d\n", irq, ret);
ret = -EBUSY;
Expand Down
3 changes: 1 addition & 2 deletions drivers/video/sa1100fb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1457,8 +1457,7 @@ static int __devinit sa1100fb_probe(struct platform_device *pdev)
if (ret)
goto failed;

ret = request_irq(irq, sa1100fb_handle_irq, IRQF_DISABLED,
"LCD", fbi);
ret = request_irq(irq, sa1100fb_handle_irq, 0, "LCD", fbi);
if (ret) {
printk(KERN_ERR "sa1100fb: request_irq failed: %d\n", ret);
goto failed;
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/sh_mobile_lcdcfb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1576,7 +1576,7 @@ static int __devinit sh_mobile_lcdc_probe(struct platform_device *pdev)

platform_set_drvdata(pdev, priv);

error = request_irq(i, sh_mobile_lcdc_irq, IRQF_DISABLED,
error = request_irq(i, sh_mobile_lcdc_irq, 0,
dev_name(&pdev->dev), priv);
if (error) {
dev_err(&pdev->dev, "unable to request irq\n");
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/tmiofb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,7 @@ static int __devinit tmiofb_probe(struct platform_device *dev)
goto err_ioremap_vram;
}

retval = request_irq(irq, &tmiofb_irq, IRQF_DISABLED,
retval = request_irq(irq, &tmiofb_irq, 0,
dev_name(&dev->dev), info);

if (retval)
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/vt8500lcdfb.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ static int __devinit vt8500lcd_probe(struct platform_device *pdev)
goto failed_free_palette;
}

ret = request_irq(irq, vt8500lcd_handle_irq, IRQF_DISABLED, "LCD", fbi);
ret = request_irq(irq, vt8500lcd_handle_irq, 0, "LCD", fbi);
if (ret) {
dev_err(&pdev->dev, "request_irq failed: %d\n", ret);
ret = -EBUSY;
Expand Down

0 comments on commit f8798cc

Please sign in to comment.