Skip to content

Commit

Permalink
leds: leds-cobalt-qube: use devm_ioremap
Browse files Browse the repository at this point in the history
The devm_ functions allocate memory that is released when a driver
detaches. This patch uses devm_ioremap() for these functions.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
  • Loading branch information
Jingoo Han authored and Bryan Wu committed Nov 26, 2012
1 parent 50e5194 commit f87ef10
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions drivers/leds/leds-cobalt-qube.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ static int __devinit cobalt_qube_led_probe(struct platform_device *pdev)
if (!res)
return -EBUSY;

led_port = ioremap(res->start, resource_size(res));
led_port = devm_ioremap(&pdev->dev, res->start, resource_size(res));
if (!led_port)
return -ENOMEM;

Expand All @@ -52,12 +52,11 @@ static int __devinit cobalt_qube_led_probe(struct platform_device *pdev)

retval = led_classdev_register(&pdev->dev, &qube_front_led);
if (retval)
goto err_iounmap;
goto err_null;

return 0;

err_iounmap:
iounmap(led_port);
err_null:
led_port = NULL;

return retval;
Expand All @@ -67,10 +66,8 @@ static int __devexit cobalt_qube_led_remove(struct platform_device *pdev)
{
led_classdev_unregister(&qube_front_led);

if (led_port) {
iounmap(led_port);
if (led_port)
led_port = NULL;
}

return 0;
}
Expand Down

0 comments on commit f87ef10

Please sign in to comment.